Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-10048

osd-ldiskfs to truncate outside of main transaction

Details

    • Bug
    • Resolution: Fixed
    • Major
    • Lustre 2.13.0
    • Lustre 2.12.0, Lustre 2.10.4, Lustre 2.10.5
    • None
    • 9223372036854775807

    Description

      this is needed to implement (transaction first; locking next) order to unify locking among MDT/OST/OUT

      Attachments

        Issue Links

          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. LU-11764 osd_declare_qid() should not rely on constant id

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. LU-11613 MDS and OSS locked up wait_transaction_locked+0x85/0xd0 [jbd2]

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-8786 Terrible i/o performance of a test application doing repeatable writes and truncates

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-11685 removing file names and freeing inodes are not atomic on the OST

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Bug - A problem which impairs or prevents the functions of the product. LU-11465 OSS/MDS deadlock in 2.10.5

          • Critical - Crashes, loss of data, severe memory leak.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-5994 DT transaction start and object lock ordering

          • Major - Major loss of function.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-13234 ldiskfs/namei.c:3310 ldiskfs_orphan_add+0x11e/0x2a0 [ldiskfs]

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-12977 fix i_mutex for ldiskfs_truncate() in osd_execute_truncate()

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-5152 Can't enforce block quota when unprivileged user change group

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Bug - A problem which impairs or prevents the functions of the product. LU-8806 LFSCK hangs on MDT - osp_precreate_cleanup_orphans - cannot cleanup orphans: rc = -107

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-10048] osd-ldiskfs to truncate outside of main transaction
            pjones Peter Jones added a comment -

            Andreas thinks yes

            pjones Peter Jones added a comment - Andreas thinks yes
            pjones Peter Jones added a comment -

            So...is this ok to mark as resolved now?

            pjones Peter Jones added a comment - So...is this ok to mark as resolved now?
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/31293/
            Subject: LU-10048 ofd: take local locks within transaction
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 9f79d4488fbb466647d1d09c2e6a1d3555d062fc

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/31293/ Subject: LU-10048 ofd: take local locks within transaction Project: fs/lustre-release Branch: master Current Patch Set: Commit: 9f79d4488fbb466647d1d09c2e6a1d3555d062fc
            adilger Andreas Dilger added a comment -

            I think the https://review.whamcloud.com/33586 patch "LU-10048 osd: async truncate" is relatively safe - it has been in master for several months already, but I'm not sure it will fix the issue completely. Also, the patch https://review.whamcloud.com/33682
            "Revert LU-5152 quota: enforce block quota for chgrp" may also help with MDT/OST lockups. It reverts a patch that was landed in 2.10.4 that introduced a circular dependency between servers in the quota handling.

            adilger Andreas Dilger added a comment - I think the https://review.whamcloud.com/33586 patch " LU-10048 osd: async truncate" is relatively safe - it has been in master for several months already, but I'm not sure it will fix the issue completely. Also, the patch https://review.whamcloud.com/33682 "Revert LU-5152 quota: enforce block quota for chgrp" may also help with MDT/OST lockups. It reverts a patch that was landed in 2.10.4 that introduced a circular dependency between servers in the quota handling.
            pjones Peter Jones added a comment -

            Mahmoud

            I would recommend holding off for now

            Peter

            pjones Peter Jones added a comment - Mahmoud I would recommend holding off for now Peter
            mhanafi Mahmoud Hanafi added a comment -

            Are the 2.10 ok to use? or do they still need additional work?

             

            mhanafi Mahmoud Hanafi added a comment - Are the 2.10 ok to use? or do they still need additional work?  
            gerrit Gerrit Updater added a comment -

            Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33587
            Subject: LU-10048 ofd: take local locks within transaction
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: 7b6cdb405a519b11537316956affc4bfa4467f8d

            gerrit Gerrit Updater added a comment - Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33587 Subject: LU-10048 ofd: take local locks within transaction Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 7b6cdb405a519b11537316956affc4bfa4467f8d
            gerrit Gerrit Updater added a comment -

            Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33586
            Subject: LU-10048 osd: async truncate
            Project: fs/lustre-release
            Branch: b2_10
            Current Patch Set: 1
            Commit: 414b3ed9fd5aa975da26b8847e9cfe8a188b59ce

            gerrit Gerrit Updater added a comment - Alex Zhuravlev (bzzz@whamcloud.com) uploaded a new patch: https://review.whamcloud.com/33586 Subject: LU-10048 osd: async truncate Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: 414b3ed9fd5aa975da26b8847e9cfe8a188b59ce
            lflis Lukasz Flis added a comment - - edited

            is there a backport for b2_10 available or planned?

            Alex pointed this issue as duplicate of LU-11465  but we were not able to cherrypick changes in b2_10

            We are experiencing MDT/OST lock-ups on 2_10_5 few times a day in the worst case

             

             

            lflis Lukasz Flis added a comment - - edited is there a backport for b2_10 available or planned? Alex pointed this issue as duplicate of LU-11465   but we were not able to cherrypick changes in b2_10 We are experiencing MDT/OST lock-ups on 2_10_5 few times a day in the worst case    
            adilger Andreas Dilger added a comment -

            Still one more patch to land.

            adilger Andreas Dilger added a comment - Still one more patch to land.
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/27488/
            Subject: LU-10048 osd: async truncate
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: cf29a5e7bfa254ccfcea023028fe7da80503c512

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/27488/ Subject: LU-10048 osd: async truncate Project: fs/lustre-release Branch: master Current Patch Set: Commit: cf29a5e7bfa254ccfcea023028fe7da80503c512

            People

              bzzz Alex Zhuravlev
              bzzz Alex Zhuravlev
              Votes:
              0 Vote for this issue
              Watchers:
              19 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: