Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-104

Lustre grants flock exclusive locks on two file descriptors for the same file

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.1.0
    • Lustre 2.1.0
    • None
    • 3
    • 22,660
    • 5058

    Description

      Lustre grants flock exclusive locks on two file descriptors for the same
      file in the same process. However, the second flock SHOULD fail.

      Fortunately, the VFS already has the correct behavior. And since we are
      already calling the flock_lock_file_wait() or posix_lock_file_wait() VFS
      calls, we just need to record that return code and return it in
      ll_file_lock().

      This patch was already landed on 1.8, needs to land on master.

      Attachments

        Activity

          [LU-104] Lustre grants flock exclusive locks on two file descriptors for the same file

          I could not really understand what was being said on the phone, so I'll start the conversation here again.

          Regardless of how the bug is fixed, I think the test from our patch should be added (or something equivalent). There was no existing test that did what our test added as far as I can see.

          morrone Christopher Morrone (Inactive) added a comment - I could not really understand what was being said on the phone, so I'll start the conversation here again. Regardless of how the bug is fixed, I think the test from our patch should be added (or something equivalent). There was no existing test that did what our test added as far as I can see.
          pjones Peter Jones added a comment -

          ok, I have marked it as a blocker and assigned it to you while you ponder. We can reassign to another engineer once you have decided the approach if you prefer

          pjones Peter Jones added a comment - ok, I have marked it as a blocker and assigned it to you while you ponder. We can reassign to another engineer once you have decided the approach if you prefer
          green Oleg Drokin added a comment -

          Yes. I think we need in in 2.1. I am still debating with myself if I need to include it verbatim or if I should add compat flag + its check for extra safety.

          green Oleg Drokin added a comment - Yes. I think we need in in 2.1. I am still debating with myself if I need to include it verbatim or if I should add compat flag + its check for extra safety.
          pjones Peter Jones added a comment -

          Oleg

          So, is the patch from bz 22040 something that we could include in Lustre 2.1?

          Peter

          pjones Peter Jones added a comment - Oleg So, is the patch from bz 22040 something that we could include in Lustre 2.1? Peter
          green Oleg Drokin added a comment -

          the flock (not posix locks you get with fcntl) in lustre is totally broken.
          The proper fix for tihs problem that actually addresses the problem at the lustre level + fixes nfs4 locking is located in bug 22040.

          green Oleg Drokin added a comment - the flock (not posix locks you get with fcntl) in lustre is totally broken. The proper fix for tihs problem that actually addresses the problem at the lustre level + fixes nfs4 locking is located in bug 22040.

          Patch for head pushed to gerrit:

          http://review.whamcloud.com/279

          morrone Christopher Morrone (Inactive) added a comment - Patch for head pushed to gerrit: http://review.whamcloud.com/279

          People

            green Oleg Drokin
            morrone Christopher Morrone (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: