[LU-104] Lustre grants flock exclusive locks on two file descriptors for the same file - Whamcloud Community JIRA

Details

Type: Bug
Resolution: Fixed
Priority: Blocker
Fix Version/s: Lustre 2.1.0
Affects Version/s: Lustre 2.1.0
Labels:
None

Severity:
3
Bugzilla ID:
22,660
Rank (Obsolete):
5058

Description

Lustre grants flock exclusive locks on two file descriptors for the same
file in the same process. However, the second flock SHOULD fail.

Fortunately, the VFS already has the correct behavior. And since we are
already calling the flock_lock_file_wait() or posix_lock_file_wait() VFS
calls, we just need to record that return code and return it in
ll_file_lock().

This patch was already landed on 1.8, needs to land on master.

Attachments

Activity

[LU-104] Lustre grants flock exclusive locks on two file descriptors for the same file

Build Master (Inactive) added a comment - 03/May/11 8:13 AM

Integrated in lustre-master » i686,server,el5,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/ldlm/ldlm_lock.c
lustre/include/lustre/lustre_idl.h
lustre/ldlm/ldlm_flock.c
lustre/tests/flock_test.c
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_internal.h
lustre/ldlm/ldlm_lockd.c
lustre/ldlm/ldlm_request.c
lustre/include/lustre_dlm.h
lustre/ldlm/ldlm_plain.c
lustre/tests/flocks_test.c
lustre/tests/sanity.sh
lustre/ldlm/ldlm_extent.c
lustre/utils/wirecheck.c
lustre/tests/Makefile.am
lustre/ptlrpc/pack_generic.c
lustre/llite/file.c
lustre/ptlrpc/wiretest.c
lustre/utils/wiretest.c

Build Master (Inactive) added a comment - 03/May/11 8:13 AM Integrated in lustre-master » i686,server,el5,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/ldlm/ldlm_lock.c lustre/include/lustre/lustre_idl.h lustre/ldlm/ldlm_flock.c lustre/tests/flock_test.c lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_internal.h lustre/ldlm/ldlm_lockd.c lustre/ldlm/ldlm_request.c lustre/include/lustre_dlm.h lustre/ldlm/ldlm_plain.c lustre/tests/flocks_test.c lustre/tests/sanity.sh lustre/ldlm/ldlm_extent.c lustre/utils/wirecheck.c lustre/tests/Makefile.am lustre/ptlrpc/pack_generic.c lustre/llite/file.c lustre/ptlrpc/wiretest.c lustre/utils/wiretest.c

Build Master (Inactive) added a comment - 03/May/11 8:02 AM

Integrated in lustre-master » i686,server,el6,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/include/lustre/lustre_idl.h
lustre/ldlm/ldlm_flock.c
lustre/ldlm/ldlm_lockd.c
lustre/tests/Makefile.am
lustre/llite/file.c
lustre/utils/wiretest.c
lustre/ldlm/ldlm_extent.c
lustre/ptlrpc/pack_generic.c
lustre/tests/sanity.sh
lustre/ldlm/ldlm_internal.h
lustre/tests/flocks_test.c
lustre/tests/flock_test.c
lustre/include/lustre_dlm.h
lustre/ldlm/ldlm_plain.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_request.c
lustre/ldlm/ldlm_lock.c
lustre/utils/wirecheck.c

Build Master (Inactive) added a comment - 03/May/11 8:02 AM Integrated in lustre-master » i686,server,el6,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/include/lustre/lustre_idl.h lustre/ldlm/ldlm_flock.c lustre/ldlm/ldlm_lockd.c lustre/tests/Makefile.am lustre/llite/file.c lustre/utils/wiretest.c lustre/ldlm/ldlm_extent.c lustre/ptlrpc/pack_generic.c lustre/tests/sanity.sh lustre/ldlm/ldlm_internal.h lustre/tests/flocks_test.c lustre/tests/flock_test.c lustre/include/lustre_dlm.h lustre/ldlm/ldlm_plain.c lustre/ptlrpc/wiretest.c lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_request.c lustre/ldlm/ldlm_lock.c lustre/utils/wirecheck.c

Build Master (Inactive) added a comment - 03/May/11 7:54 AM

Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/tests/flock_test.c
lustre/llite/file.c
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_plain.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_lock.c
lustre/ldlm/ldlm_lockd.c
lustre/ldlm/ldlm_flock.c
lustre/ldlm/ldlm_internal.h
lustre/tests/sanity.sh
lustre/tests/flocks_test.c
lustre/utils/wiretest.c
lustre/include/lustre_dlm.h
lustre/utils/wirecheck.c
lustre/ldlm/ldlm_request.c
lustre/tests/Makefile.am
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_extent.c
lustre/include/lustre/lustre_idl.h

Build Master (Inactive) added a comment - 03/May/11 7:54 AM Integrated in lustre-master » x86_64,client,ubuntu1004,ofa #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/tests/flock_test.c lustre/llite/file.c lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_plain.c lustre/ptlrpc/wiretest.c lustre/ldlm/ldlm_lock.c lustre/ldlm/ldlm_lockd.c lustre/ldlm/ldlm_flock.c lustre/ldlm/ldlm_internal.h lustre/tests/sanity.sh lustre/tests/flocks_test.c lustre/utils/wiretest.c lustre/include/lustre_dlm.h lustre/utils/wirecheck.c lustre/ldlm/ldlm_request.c lustre/tests/Makefile.am lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_extent.c lustre/include/lustre/lustre_idl.h

Build Master (Inactive) added a comment - 03/May/11 7:53 AM

Integrated in lustre-master » i686,server,el5,ofa #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/tests/flocks_test.c
lustre/tests/Makefile.am
lustre/utils/wiretest.c
lustre/ldlm/ldlm_internal.h
lustre/ldlm/ldlm_lockd.c
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_lock.c
lustre/include/lustre/lustre_idl.h
lustre/tests/sanity.sh
lustre/ldlm/ldlm_request.c
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_extent.c
lustre/utils/wirecheck.c
lustre/ldlm/ldlm_plain.c
lustre/tests/flock_test.c
lustre/include/lustre_dlm.h
lustre/ldlm/ldlm_flock.c
lustre/llite/file.c
lustre/ptlrpc/wiretest.c

Build Master (Inactive) added a comment - 03/May/11 7:53 AM Integrated in lustre-master » i686,server,el5,ofa #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/tests/flocks_test.c lustre/tests/Makefile.am lustre/utils/wiretest.c lustre/ldlm/ldlm_internal.h lustre/ldlm/ldlm_lockd.c lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_lock.c lustre/include/lustre/lustre_idl.h lustre/tests/sanity.sh lustre/ldlm/ldlm_request.c lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_extent.c lustre/utils/wirecheck.c lustre/ldlm/ldlm_plain.c lustre/tests/flock_test.c lustre/include/lustre_dlm.h lustre/ldlm/ldlm_flock.c lustre/llite/file.c lustre/ptlrpc/wiretest.c

Build Master (Inactive) added a comment - 03/May/11 7:50 AM

Integrated in lustre-master » x86_64,client,el6,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/ldlm/ldlm_flock.c
lustre/tests/sanity.sh
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_request.c
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_lock.c
lustre/ldlm/ldlm_lockd.c
lustre/tests/Makefile.am
lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/ldlm/ldlm_extent.c
lustre/llite/file.c
lustre/tests/flocks_test.c
lustre/ldlm/ldlm_plain.c
lustre/utils/wirecheck.c
lustre/include/lustre_dlm.h
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_internal.h
lustre/tests/flock_test.c

Build Master (Inactive) added a comment - 03/May/11 7:50 AM Integrated in lustre-master » x86_64,client,el6,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/ldlm/ldlm_flock.c lustre/tests/sanity.sh lustre/ptlrpc/wiretest.c lustre/ldlm/ldlm_request.c lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_lock.c lustre/ldlm/ldlm_lockd.c lustre/tests/Makefile.am lustre/utils/wiretest.c lustre/include/lustre/lustre_idl.h lustre/ldlm/ldlm_extent.c lustre/llite/file.c lustre/tests/flocks_test.c lustre/ldlm/ldlm_plain.c lustre/utils/wirecheck.c lustre/include/lustre_dlm.h lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_internal.h lustre/tests/flock_test.c

Build Master (Inactive) added a comment - 03/May/11 7:46 AM

Integrated in lustre-master » x86_64,client,el5,ofa #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/tests/Makefile.am
lustre/tests/sanity.sh
lustre/tests/flock_test.c
lustre/ldlm/ldlm_extent.c
lustre/utils/wiretest.c
lustre/ldlm/ldlm_flock.c
lustre/include/lustre_dlm.h
lustre/ldlm/ldlm_plain.c
lustre/ldlm/ldlm_lock.c
lustre/include/lustre/lustre_idl.h
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_lockd.c
lustre/tests/flocks_test.c
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_internal.h
lustre/ldlm/ldlm_request.c
lustre/ptlrpc/wiretest.c
lustre/utils/wirecheck.c
lustre/llite/file.c

Build Master (Inactive) added a comment - 03/May/11 7:46 AM Integrated in lustre-master » x86_64,client,el5,ofa #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/tests/Makefile.am lustre/tests/sanity.sh lustre/tests/flock_test.c lustre/ldlm/ldlm_extent.c lustre/utils/wiretest.c lustre/ldlm/ldlm_flock.c lustre/include/lustre_dlm.h lustre/ldlm/ldlm_plain.c lustre/ldlm/ldlm_lock.c lustre/include/lustre/lustre_idl.h lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_lockd.c lustre/tests/flocks_test.c lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_internal.h lustre/ldlm/ldlm_request.c lustre/ptlrpc/wiretest.c lustre/utils/wirecheck.c lustre/llite/file.c

Build Master (Inactive) added a comment - 03/May/11 7:39 AM

Integrated in lustre-master » i686,client,el6,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/tests/flocks_test.c
lustre/tests/Makefile.am
lustre/include/lustre/lustre_idl.h
lustre/include/lustre_dlm.h
lustre/ldlm/ldlm_internal.h
lustre/ldlm/ldlm_plain.c
lustre/utils/wiretest.c
lustre/ldlm/ldlm_extent.c
lustre/llite/file.c
lustre/ptlrpc/pack_generic.c
lustre/utils/wirecheck.c
lustre/ldlm/ldlm_lockd.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_request.c
lustre/ldlm/ldlm_flock.c
lustre/tests/sanity.sh
lustre/tests/flock_test.c
lustre/ldlm/ldlm_lock.c
lustre/ldlm/ldlm_inodebits.c

Build Master (Inactive) added a comment - 03/May/11 7:39 AM Integrated in lustre-master » i686,client,el6,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/tests/flocks_test.c lustre/tests/Makefile.am lustre/include/lustre/lustre_idl.h lustre/include/lustre_dlm.h lustre/ldlm/ldlm_internal.h lustre/ldlm/ldlm_plain.c lustre/utils/wiretest.c lustre/ldlm/ldlm_extent.c lustre/llite/file.c lustre/ptlrpc/pack_generic.c lustre/utils/wirecheck.c lustre/ldlm/ldlm_lockd.c lustre/ptlrpc/wiretest.c lustre/ldlm/ldlm_request.c lustre/ldlm/ldlm_flock.c lustre/tests/sanity.sh lustre/tests/flock_test.c lustre/ldlm/ldlm_lock.c lustre/ldlm/ldlm_inodebits.c

Build Master (Inactive) added a comment - 03/May/11 7:36 AM

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/ldlm/ldlm_lock.c
lustre/utils/wirecheck.c
lustre/llite/file.c
lustre/ldlm/ldlm_internal.h
lustre/tests/Makefile.am
lustre/ldlm/ldlm_extent.c
lustre/include/lustre_dlm.h
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_plain.c
lustre/utils/wiretest.c
lustre/include/lustre/lustre_idl.h
lustre/ldlm/ldlm_lockd.c
lustre/tests/flocks_test.c
lustre/ldlm/ldlm_flock.c
lustre/tests/sanity.sh
lustre/ptlrpc/wiretest.c
lustre/tests/flock_test.c
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_request.c

Build Master (Inactive) added a comment - 03/May/11 7:36 AM Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/ldlm/ldlm_lock.c lustre/utils/wirecheck.c lustre/llite/file.c lustre/ldlm/ldlm_internal.h lustre/tests/Makefile.am lustre/ldlm/ldlm_extent.c lustre/include/lustre_dlm.h lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_plain.c lustre/utils/wiretest.c lustre/include/lustre/lustre_idl.h lustre/ldlm/ldlm_lockd.c lustre/tests/flocks_test.c lustre/ldlm/ldlm_flock.c lustre/tests/sanity.sh lustre/ptlrpc/wiretest.c lustre/tests/flock_test.c lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_request.c

Build Master (Inactive) added a comment - 03/May/11 7:35 AM

Integrated in lustre-master » x86_64,server,el6,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/utils/wiretest.c
lustre/tests/flocks_test.c
lustre/ldlm/ldlm_plain.c
lustre/ldlm/ldlm_request.c
lustre/ldlm/ldlm_inodebits.c
lustre/include/lustre/lustre_idl.h
lustre/utils/wirecheck.c
lustre/tests/flock_test.c
lustre/ldlm/ldlm_flock.c
lustre/ldlm/ldlm_lock.c
lustre/ldlm/ldlm_extent.c
lustre/tests/sanity.sh
lustre/ldlm/ldlm_internal.h
lustre/tests/Makefile.am
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_lockd.c
lustre/ptlrpc/wiretest.c
lustre/include/lustre_dlm.h
lustre/llite/file.c

Build Master (Inactive) added a comment - 03/May/11 7:35 AM Integrated in lustre-master » x86_64,server,el6,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/utils/wiretest.c lustre/tests/flocks_test.c lustre/ldlm/ldlm_plain.c lustre/ldlm/ldlm_request.c lustre/ldlm/ldlm_inodebits.c lustre/include/lustre/lustre_idl.h lustre/utils/wirecheck.c lustre/tests/flock_test.c lustre/ldlm/ldlm_flock.c lustre/ldlm/ldlm_lock.c lustre/ldlm/ldlm_extent.c lustre/tests/sanity.sh lustre/ldlm/ldlm_internal.h lustre/tests/Makefile.am lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_lockd.c lustre/ptlrpc/wiretest.c lustre/include/lustre_dlm.h lustre/llite/file.c

Build Master (Inactive) added a comment - 03/May/11 7:35 AM

Integrated in lustre-master » x86_64,client,el5,inkernel #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/utils/wirecheck.c
lustre/tests/sanity.sh
lustre/ldlm/ldlm_lockd.c
lustre/include/lustre/lustre_idl.h
lustre/ldlm/ldlm_lock.c
lustre/utils/wiretest.c
lustre/ldlm/ldlm_extent.c
lustre/ldlm/ldlm_inodebits.c
lustre/tests/Makefile.am
lustre/ldlm/ldlm_request.c
lustre/ptlrpc/pack_generic.c
lustre/ldlm/ldlm_internal.h
lustre/ldlm/ldlm_plain.c
lustre/llite/file.c
lustre/ldlm/ldlm_flock.c
lustre/tests/flock_test.c
lustre/ptlrpc/wiretest.c
lustre/tests/flocks_test.c
lustre/include/lustre_dlm.h

Build Master (Inactive) added a comment - 03/May/11 7:35 AM Integrated in lustre-master » x86_64,client,el5,inkernel #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/utils/wirecheck.c lustre/tests/sanity.sh lustre/ldlm/ldlm_lockd.c lustre/include/lustre/lustre_idl.h lustre/ldlm/ldlm_lock.c lustre/utils/wiretest.c lustre/ldlm/ldlm_extent.c lustre/ldlm/ldlm_inodebits.c lustre/tests/Makefile.am lustre/ldlm/ldlm_request.c lustre/ptlrpc/pack_generic.c lustre/ldlm/ldlm_internal.h lustre/ldlm/ldlm_plain.c lustre/llite/file.c lustre/ldlm/ldlm_flock.c lustre/tests/flock_test.c lustre/ptlrpc/wiretest.c lustre/tests/flocks_test.c lustre/include/lustre_dlm.h

Build Master (Inactive) added a comment - 03/May/11 7:33 AM

Integrated in lustre-master » x86_64,server,el5,ofa #101
~~LU-104~~ Properly address ownership of posix and flock locks

Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f
Files :

lustre/ldlm/ldlm_lock.c
lustre/llite/file.c
lustre/tests/flocks_test.c
lustre/tests/flock_test.c
lustre/utils/wirecheck.c
lustre/include/lustre/lustre_idl.h
lustre/include/lustre_dlm.h
lustre/utils/wiretest.c
lustre/ldlm/ldlm_request.c
lustre/ldlm/ldlm_inodebits.c
lustre/ldlm/ldlm_plain.c
lustre/ldlm/ldlm_lockd.c
lustre/ptlrpc/pack_generic.c
lustre/ptlrpc/wiretest.c
lustre/ldlm/ldlm_extent.c
lustre/ldlm/ldlm_flock.c
lustre/tests/sanity.sh
lustre/ldlm/ldlm_internal.h
lustre/tests/Makefile.am

Build Master (Inactive) added a comment - 03/May/11 7:33 AM Integrated in lustre-master » x86_64,server,el5,ofa #101 LU-104 Properly address ownership of posix and flock locks Oleg Drokin : 3bb8d1b9656994b0313cdba6ad8eeb7b84f5ee9f Files : lustre/ldlm/ldlm_lock.c lustre/llite/file.c lustre/tests/flocks_test.c lustre/tests/flock_test.c lustre/utils/wirecheck.c lustre/include/lustre/lustre_idl.h lustre/include/lustre_dlm.h lustre/utils/wiretest.c lustre/ldlm/ldlm_request.c lustre/ldlm/ldlm_inodebits.c lustre/ldlm/ldlm_plain.c lustre/ldlm/ldlm_lockd.c lustre/ptlrpc/pack_generic.c lustre/ptlrpc/wiretest.c lustre/ldlm/ldlm_extent.c lustre/ldlm/ldlm_flock.c lustre/tests/sanity.sh lustre/ldlm/ldlm_internal.h lustre/tests/Makefile.am

People

Assignee:: Oleg Drokin

Reporter:: Christopher Morrone (Inactive)

Votes:: 0 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 28/Feb/11 5:52 PM

Updated:: 28/Jun/11 7:50 PM

Resolved:: 03/May/11 7:18 AM