[LU-10579] chlg: -1(null) changelog for setfattr on trusted.*

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.10.6
• Severity: 3
• Assignee: John Hammond
• Reporter: CEA

Description

There seems to be an issue with XATTR changelogs for some specific prefixes such as trusted or security, but not user.

# bash lustre/tests/llmount.sh
# touch /mnt/lustre/blob
# lctl --device lustre-MDT0000 changelog_register
# setfattr -n trusted.test -v test /mnt/lustre/blob
# lfs changelog lustre-MDT0000
1 -1(null) 08:13:35.501636480 2018.01.30 0x0 t=[0x200000401:0x1:0x0] j=setfattr.0 ef=0x1 u=0:0
# setfattr -n user.test -v test /mnt/lustre/blob
# lfs changelog lustre-MDT0000
1 -1(null) 08:13:35.501636480 2018.01.30 0x0 t=[0x200000401:0x1:0x0] j=setfattr.0 ef=0x1 u=0:0
2 15XATTR 08:13:21.191376815 2018.01.30 0x0 t=[0x200000401:0x1:0x0] j=setfattr.0 ef=0x1 u=0:0

Comments

[Peter Jones]

Landed for 2.10.6. Not needed for master

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/33048/
Subject: LU-10579 mdd: emit changelogs for security and trusted xattrs
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: ab246d23566d7da1a41479b688833f47976b6428

[Olaf Weber (Inactive)]

Expanding a bit on my previous comment.

What I'm looking for is the completion of this sentence: "No changelog processor should be notified of changes to an extended attribute named like this because ..."

Maybe there is one. But until there is one, I continue to think we should emit changelog entries for changes to every extended attribute.

[Olaf Weber (Inactive)]

Hi John,

As noted, my preference would be to just emit the changelog event in all cases. It is simpler to code, and I do not see the value of suppressing the events for certain xattrs. So returning CL_SETXATTR for all the "other" cases has my vote.

[John Hammond]

Hi Olaf,

Sorry, I didn't read your comments as carefully as I should have.

I think we can add a negative sentinel value to the enum that forces the compiler to use a signed type for it. Or return CL_SETXATTR as a catch all type.

[Olaf Weber (Inactive)]

Note that 33048 doesn't address the issue that returning -1 from mdd_xattr_changelog_type() does not, in fact, suppress the generation of a changelog entry.

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: https://review.whamcloud.com/33048
Subject: LU-10579 mdd: emit changelogs for securit* and trusted xattrs
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 9958d6f33212d818a439801b88c480207e449908

[John Hammond]

Fixed in 2.11 by https://review.whamcloud.com/28251 LU-9727 lustre: add CL_GETXATTR for Changelogs.