Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-12428

sanity-sec: test_13 nodemap_del failed with 1

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.13.0
    • Lustre 2.13.0
    • None
    • 3
    • 9223372036854775807

    Description

      This issue was created by maloo for Li Xi <pkuelelixi@gmail.com>

      This issue relates to the following test suite run: https://testing.whamcloud.com/test_sets/2fe8e80e-8cce-11e9-abe3-52540065bddc

      By checking the test logs, we can find that in test_13, after running "lctl nodemap_del 48714_1", the test script check whether the nodemap has been deleted or not immediately in delete_nodemaps() of sanity-sec.sh. However, "lctl get_param nodemap.48714_1.id" still prints a result, which is unexpected by delete_nodemaps(). And thus, delete_nodemaps() quit with error reporting failure of test_13.

      test_14 and test_15 failed too, but that is consequence of test_13 failure. In test_13, delete_nodemaps() didn't remove the existing nodemaps after 48714_1, so the nodemap_add of 48714_2 fails.

      I think we need to have improvemens here. test_13, test_14 and test_15 are unrelated, so before running these test cases, delete_nodemaps() need to delete existing nodemaps to avoid failure.

      Attachments

        Activity

          [LU-12428] sanity-sec: test_13 nodemap_del failed with 1
          pjones Peter Jones made changes -
          Resolution New: Fixed [ 1 ]
          Status Original: Reopened [ 4 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.13

          pjones Peter Jones added a comment - Landed for 2.13

          Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36009/
          Subject: LU-12428 tests: fix sanity-sec wait_nm_sync
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: ab398920fc20986a8ec686cad984f0cf0145a8d9

          gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/36009/ Subject: LU-12428 tests: fix sanity-sec wait_nm_sync Project: fs/lustre-release Branch: master Current Patch Set: Commit: ab398920fc20986a8ec686cad984f0cf0145a8d9

          Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/36009
          Subject: LU-12428 tests: fix sanity-sec wait_nm_sync
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 83526c493048e6f2a1ddf0bbf7cdf48d40982d16

          gerrit Gerrit Updater added a comment - Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/36009 Subject: LU-12428 tests: fix sanity-sec wait_nm_sync Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 83526c493048e6f2a1ddf0bbf7cdf48d40982d16

          Oh, I finally found out the reason behind this strange behavior with wait_nm_sync() in sanity-sec.sh.
          In fact, after a bad rebase, patch https://review.whamcloud.com/34090 introduced a different version of the wait_nm_sync() function in the same script sanity-sec.sh.

          sebastien Sebastien Buisson added a comment - Oh, I finally found out the reason behind this strange behavior with wait_nm_sync() in sanity-sec.sh. In fact, after a bad rebase, patch https://review.whamcloud.com/34090 introduced a different version of the wait_nm_sync() function in the same script sanity-sec.sh.

          Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/35990
          Subject: LU-12428 tests: robustify 'inactive' option of wait_nm_sync
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: c88a2d5a4a6c576ca79d71e5e331811246a94605

          gerrit Gerrit Updater added a comment - Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/35990 Subject: LU-12428 tests: robustify 'inactive' option of wait_nm_sync Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: c88a2d5a4a6c576ca79d71e5e331811246a94605

          Hmm, when comparing test log from one of the recent failures (https://testing.whamcloud.com/test_sets/969517b8-c9a9-11e9-9fc9-52540065bddc) and test log from patch https://review.whamcloud.com/35421/ when it passed Maloo (https://testing.whamcloud.com/sub_tests/7f7dee14-9f70-11e9-9e3d-52540065bddc), it appears that there are no such message as "On MGS 10.9.4.124, 40996_0.id = nodemap.40996_0.id=1" in the failure case.
          It means wait_nm_sync did not do its job, possibly because of the empty third parameter not taken into account properly. I will push a patch to make that more robust.

          sebastien Sebastien Buisson added a comment - Hmm, when comparing test log from one of the recent failures ( https://testing.whamcloud.com/test_sets/969517b8-c9a9-11e9-9fc9-52540065bddc ) and test log from patch https://review.whamcloud.com/35421/ when it passed Maloo ( https://testing.whamcloud.com/sub_tests/7f7dee14-9f70-11e9-9e3d-52540065bddc ), it appears that there are no such message as "On MGS 10.9.4.124, 40996_0.id = nodemap.40996_0.id=1" in the failure case. It means wait_nm_sync did not do its job, possibly because of the empty third parameter not taken into account properly. I will push a patch to make that more robust.
          yujian Jian Yu made changes -
          Resolution Original: Fixed [ 1 ]
          Status Original: Resolved [ 5 ] New: Reopened [ 4 ]
          yujian Jian Yu added a comment - The failure occurred 5 times on master branch last week: https://testing.whamcloud.com/test_sets/969517b8-c9a9-11e9-9fc9-52540065bddc https://testing.whamcloud.com/test_sets/bc4a1c04-c843-11e9-a25b-52540065bddc https://testing.whamcloud.com/test_sets/eeb69820-c811-11e9-a2b6-52540065bddc
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.13.0 [ 14290 ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]

          People

            sebastien Sebastien Buisson
            maloo Maloo
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: