[LU-14431] error messages that do not stop with newline

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Affects Version/s: Lustre 2.12.6
• Labels: easy
• Assignee: Feng Lei
• Reporter: Li Xi

Description

When I am using grep to check how many CERROR in the codes, I found there are still a dozen of error messages that do not end with a newline. That will cause annoying messages in system log.

lnet/klnds/gnilnd/gnilnd_cb.c(2378):

			CERROR("Unexpected connstamp %#llx(%#llx expected)"
				" from %s", rxmsg->gnm_connstamp,
				found_conn->gnc_peer_connstamp,
				libcfs_nid2str(peer->gnp_nid));

lnet/klnds/gnilnd/gnilnd_conn.c(867):

			CERROR("Looking up network: device is in shutdown");

lustre/ptlrpc/service.c(731):

				CERROR("%s: invalid CPT pattern string: %s",
				       conf->psc_name, cconf->cc_pattern);

lustre/ptlrpc/ptlrpcd.c(754):

			CERROR("%s: invalid CPT pattern string: %s",
			       "ptlrpcd_cpts", ptlrpcd_cpts);

lustre/include/lustre_dlm.h(1159):

			CERROR("lock %p: delayed lvb init failed (rc %d)",
			       lock, rc);

lustre/quota/qmt_lock.c(761):

		CERROR("%s: failed to init env.", qmt->qmt_svname);

lustre/osd-ldiskfs/osd_handler.c(2377):

				CERROR("%s: unsupported checksum type of "
				       "T10PI type '%s'",
				       d->od_svname, name);

lustre/osd-ldiskfs/osd_handler.c(2382):

			CERROR("%s: unsupported T10PI type '%s'",
			       d->od_svname, name);

lustre/target/tgt_handler.c(945):

		CERROR("No target passed");

lustre/obdclass/lprocfs_status.c(78):

		CERROR("LprocFS: No memory to create <debugfs> entry %s", name);

Issue Links

• is related to: LU-14475 Make too short log messages meanful

Comments

[Li Xi]

Space is missing after ")":

lustre/ptlrpc/nodemap_handler.c(1134):
                 CERROR("cannot allocate memory (%zu bytes)"
                        "for nodemap '%s'\n", sizeof(*nodemap),
                        name);

[Li Xi]

Space is missing after ":":

lnet/klnds/gnilnd/gnilnd_conn.c(64):
                                CERROR("FATAL:fmablk registration has failed "
                                       "for %ld seconds.\n",
                                       cfs_duration_sec(jiffies - reg_to) +
                                                rfto);

[Li Xi]

Space is missing after "response"

lnet/lnet/acceptor.c(296):
                         CERROR("Error sending magic+version in response"
                               "to version %d from %pI4h: %d\n",
                              peer_version, &peer_ip, rc);

lnet/lnet/acceptor.c(250):
                               CERROR("Error sending magic+version in response"
                                      "to LNET magic from %pI4h: %d\n",
                                       &peer_ip, rc);

[Li Xi]

The space before ":" should be removed

lustre/ofd/ofd_dev.c(1605):
				CERROR("%s : invalid o_seq "DOSTID"\n",
				       ofd_name(ofd), POSTID(&oa->o_oi));

[Li Xi]

There is no way guess what the following message is related to without reading the codes:

lustre/obdclass/lu_object.c(2284):
                        CERROR("[%d]: %p %x (%p,%p,%p) %d %d \"%s\"@%p\n",
                               i, key, key->lct_tags,
                               key->lct_init, key->lct_fini, key->lct_exit,
			       key->lct_index, atomic_read(&key->lct_used),
                               key->lct_owner ? key->lct_owner->name : "",
                               key->lct_owner);

Adding a prefix string like "dumping context keys" would help a lot.

[Li Xi]

The following message missed a space after "%llu"

lustre/llite/statahead.c(1320):
			CERROR("%s: reading dir "DFID" at %llu"
			       "opendir_pid = %u : rc = %d\n",
			       ll_i2sbi(dir)->ll_fsname,
			       PFID(ll_inode2fid(dir)), pos,
			       lli->lli_opendir_pid, rc);

[Li Xi]

The following message missed a space after "string" and missing ": rc = %d" at the end

lustre/llite/symlink.c(102):
		CERROR("%s: inode "DFID": symlink not NULL terminated string"
		       "of length %d\n", sbi->ll_fsname,
		       PFID(ll_inode2fid(inode)), symlen - 1);

[Li Xi]

The following two messages has weird ":" around DFID, change them to spaces would be better:

lustre/mdd/mdd_object.c(1586):
			CERROR("%s: failed to rollback of layout of: "DFID
			       ": %d, file state unknown\n",
			       mdd_obj_dev_name(obj), PFID(mdo2fid(obj)), rc2);
lustre/mdd/mdd_object.c(1818):
			CERROR("%s: failed to rollback of layout of: "DFID
			       ": %d, file state unkonwn.\n",
			       mdd_obj_dev_name(obj), PFID(mdo2fid(obj)), rc2);

[Li Xi]

The following message does not have space after DFID

lustre/mdd/mdd_object.c(2574):
			CERROR("%s: unable to roll back layout swap. FIDs: "
			       DFID" and "DFID "error: %d/%d, steps: %d\n",
			       mdd_obj_dev_name(fst_o),
			       PFID(mdo2fid(snd_o)), PFID(mdo2fid(fst_o)),
			       rc, rc2, steps);

[Li Xi]

The following message has tailing ":" but is missing "rc = %d\n" at the end:

lustre/llite/llite_lib.c(1467):
		CERROR("%s: "DFID" dir layout mismatch:\n",
		       ll_i2sbi(inode)->ll_fsname,
		       PFID(&lli->lli_fid));

[Li Xi]

The following message does not have space before "opendir_pid":

lustre/llite/statahead.c(1320):
			CERROR("%s: reading dir "DFID" at %llu"
			       "opendir_pid = %u : rc = %d\n",
			       ll_i2sbi(dir)->ll_fsname,
			       PFID(ll_inode2fid(dir)), pos,
			       lli->lli_opendir_pid, rc);