Details
-
Improvement
-
Resolution: Fixed
-
Minor
-
None
-
Lustre 2.12.6
-
9223372036854775807
Description
When I am using grep to check how many CERROR in the codes, I found there are still a dozen of error messages that do not end with a newline. That will cause annoying messages in system log.
lnet/klnds/gnilnd/gnilnd_cb.c(2378):
CERROR("Unexpected connstamp %#llx(%#llx expected)" " from %s", rxmsg->gnm_connstamp, found_conn->gnc_peer_connstamp, libcfs_nid2str(peer->gnp_nid));
lnet/klnds/gnilnd/gnilnd_conn.c(867):
CERROR("Looking up network: device is in shutdown");
lustre/ptlrpc/service.c(731):
CERROR("%s: invalid CPT pattern string: %s", conf->psc_name, cconf->cc_pattern);
lustre/ptlrpc/ptlrpcd.c(754):
CERROR("%s: invalid CPT pattern string: %s", "ptlrpcd_cpts", ptlrpcd_cpts);
lustre/include/lustre_dlm.h(1159):
CERROR("lock %p: delayed lvb init failed (rc %d)", lock, rc);
lustre/quota/qmt_lock.c(761):
CERROR("%s: failed to init env.", qmt->qmt_svname);
lustre/osd-ldiskfs/osd_handler.c(2377):
CERROR("%s: unsupported checksum type of " "T10PI type '%s'", d->od_svname, name);
lustre/osd-ldiskfs/osd_handler.c(2382):
CERROR("%s: unsupported T10PI type '%s'", d->od_svname, name);
lustre/target/tgt_handler.c(945):
CERROR("No target passed");
lustre/obdclass/lprocfs_status.c(78):
CERROR("LprocFS: No memory to create <debugfs> entry %s", name);
Attachments
Issue Links
- is related to
-
LU-14475 Make too short log messages meanful
-
- Resolved
-
All of the missing space errors will go away with single-line error strings, which is one reason why they are recommended by checkpatch. The other is that it makes fining error strings in the code much easier, since words in the error will not be split across lines.