[LU-14431] error messages that do not stop with newline

• Type: Improvement
• Resolution: Fixed
• Priority: Minor
• Affects Version/s: Lustre 2.12.6
• Labels: easy
• Assignee: Feng Lei
• Reporter: Li Xi

Description

When I am using grep to check how many CERROR in the codes, I found there are still a dozen of error messages that do not end with a newline. That will cause annoying messages in system log.

lnet/klnds/gnilnd/gnilnd_cb.c(2378):

			CERROR("Unexpected connstamp %#llx(%#llx expected)"
				" from %s", rxmsg->gnm_connstamp,
				found_conn->gnc_peer_connstamp,
				libcfs_nid2str(peer->gnp_nid));

lnet/klnds/gnilnd/gnilnd_conn.c(867):

			CERROR("Looking up network: device is in shutdown");

lustre/ptlrpc/service.c(731):

				CERROR("%s: invalid CPT pattern string: %s",
				       conf->psc_name, cconf->cc_pattern);

lustre/ptlrpc/ptlrpcd.c(754):

			CERROR("%s: invalid CPT pattern string: %s",
			       "ptlrpcd_cpts", ptlrpcd_cpts);

lustre/include/lustre_dlm.h(1159):

			CERROR("lock %p: delayed lvb init failed (rc %d)",
			       lock, rc);

lustre/quota/qmt_lock.c(761):

		CERROR("%s: failed to init env.", qmt->qmt_svname);

lustre/osd-ldiskfs/osd_handler.c(2377):

				CERROR("%s: unsupported checksum type of "
				       "T10PI type '%s'",
				       d->od_svname, name);

lustre/osd-ldiskfs/osd_handler.c(2382):

			CERROR("%s: unsupported T10PI type '%s'",
			       d->od_svname, name);

lustre/target/tgt_handler.c(945):

		CERROR("No target passed");

lustre/obdclass/lprocfs_status.c(78):

		CERROR("LprocFS: No memory to create <debugfs> entry %s", name);

Issue Links

• is related to: LU-14475 Make too short log messages meanful

Comments

[Andreas Dilger]

I've gone through and used strikeout on the messages that have already been fixed. There are still a few that could be done before closing the ticket.

[Andreas Dilger]

I think there is still more to be done here.

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/41723/
Subject: LU-14431 log: Add ending newline for some messages.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 503bf7f29a49914082480a7cdceb914e42a95dd8

[James A Simmons]

The current patch missed a few so another patch will be coming.