Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-14645

setstripe cleanup

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.16.0, Lustre 2.15.3
    • Lustre 2.15.0
    • None
    • 3
    • 9223372036854775807

    Description

      lfs setstripe checks stripe parameters differently for PFL and !PFL layouts, make them symmetric.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. LU-11264 llapi_* routines demonstrate poor performance

          • Major - Major loss of function.
          • Open

          Activity

            [LU-14645] setstripe cleanup
            spitzcor Cory Spitz added a comment -

            Sorry, I missed your request. Right, it needs to be fixed or reverted. Thanks for putting it on the blocker list for 2.15.0.

            spitzcor Cory Spitz added a comment - Sorry, I missed your request. Right, it needs to be fixed or reverted. Thanks for putting it on the blocker list for 2.15.0.
            adilger Andreas Dilger added a comment -

            Hi Vitaly, Cory,
            there were some defects introduced with the patch https://review.whamcloud.com/43465 "LU-14645 utils: setstripe cleanup" that need to be fixed before the 2.15 release. That patch is changing the function signature of llapi_layout_sanity(), which breaks both the API and ABI for that function. The llapi_ functions are supposed to have consistent API and ABI across releases, so this needs to be fixed or the patch reverted before the 2.15.0 release.

            adilger Andreas Dilger added a comment - Hi Vitaly, Cory, there were some defects introduced with the patch https://review.whamcloud.com/43465 " LU-14645 utils: setstripe cleanup" that need to be fixed before the 2.15 release. That patch is changing the function signature of llapi_layout_sanity() , which breaks both the API and ABI for that function. The llapi_ functions are supposed to have consistent API and ABI across releases, so this needs to be fixed or the patch reverted before the 2.15.0 release.
            adilger Andreas Dilger added a comment -

            Hi Vitaly, Cory,
            there were some defects introduced with the patch https://review.whamcloud.com/43465 "LU-14645 utils: setstripe cleanup" that need to be fixed before the 2.15 release. Could you please take a look at my (post landing) review comments on that patch.

            adilger Andreas Dilger added a comment - Hi Vitaly, Cory, there were some defects introduced with the patch https://review.whamcloud.com/43465 " LU-14645 utils: setstripe cleanup " that need to be fixed before the 2.15 release. Could you please take a look at my (post landing) review comments on that patch.
            adilger Andreas Dilger added a comment -

            Hi Vitaly, could you please respond to the issues I posted on your patch https://review.whamcloud.com/43465 "LU-14645 utils: setstripe cleanup" and submit a patch to fix them.

            adilger Andreas Dilger added a comment - Hi Vitaly, could you please respond to the issues I posted on your patch https://review.whamcloud.com/43465 " LU-14645 utils: setstripe cleanup " and submit a patch to fix them.
            adilger Andreas Dilger added a comment -

            There are several issues with the patch that landed under this ticket that need to be fixed before the 2.15.0 release is madee.

            adilger Andreas Dilger added a comment - There are several issues with the patch that landed under this ticket that need to be fixed before the 2.15.0 release is madee.
            pjones Peter Jones added a comment -

            Landed for 2.15

            pjones Peter Jones added a comment - Landed for 2.15
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43465/
            Subject: LU-14645 utils: setstripe cleanup
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 149934fe28dac22a51ec9b2873c4f215cb204947

            gerrit Gerrit Updater added a comment - Oleg Drokin (green@whamcloud.com) merged in patch https://review.whamcloud.com/43465/ Subject: LU-14645 utils: setstripe cleanup Project: fs/lustre-release Branch: master Current Patch Set: Commit: 149934fe28dac22a51ec9b2873c4f215cb204947
            gerrit Gerrit Updater added a comment -

            Vitaly Fertman (vitaly.fertman@hpe.com) uploaded a new patch: https://review.whamcloud.com/43465
            Subject: LU-14645 utils: setstripe cleanup
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 41e16bebbfad66ef60032f58f529e37ea4787456

            gerrit Gerrit Updater added a comment - Vitaly Fertman (vitaly.fertman@hpe.com) uploaded a new patch: https://review.whamcloud.com/43465 Subject: LU-14645 utils: setstripe cleanup Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 41e16bebbfad66ef60032f58f529e37ea4787456

            People

              vitaly_fertman Vitaly Fertman
              vitaly_fertman Vitaly Fertman
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: