[LU-14645] setstripe cleanup

• Type: Bug
• Resolution: Fixed
• Priority: Blocker
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.3
• Affects Version/s: Lustre 2.15.0
• Severity: 3
• Assignee: Vitaly Fertman
• Reporter: Vitaly Fertman

Description

lfs setstripe checks stripe parameters differently for PFL and !PFL layouts, make them symmetric.

Issue Links

• is related to: LU-11264 llapi_* routines demonstrate poor performance

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/46151/
Subject: LU-14645 utils: fix API for llapi_sanity_check
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5e65d6a8e57a5a17c4c7e043cb46e86bf82b7782

[Gerrit Updater]

"Vitaly Fertman <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/46152
Subject: LU-14645 utils: optimise setstripe
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 3f0ff1605de5e65908686d90d4b69e9028d4e4aa

[Gerrit Updater]

"Vitaly Fertman <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/46151
Subject: LU-14645 utils: fix API for llapi_sanity_check
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 05000fb5cb641abb5c07b169dd32ac1ea6412d1f

[Cory Spitz]

Sorry, I missed your request. Right, it needs to be fixed or reverted. Thanks for putting it on the blocker list for 2.15.0.

[Andreas Dilger]

Hi Vitaly, Cory,
there were some defects introduced with the patch https://review.whamcloud.com/43465 "LU-14645 utils: setstripe cleanup" that need to be fixed before the 2.15 release. That patch is changing the function signature of llapi_layout_sanity(), which breaks both the API and ABI for that function. The llapi_ functions are supposed to have consistent API and ABI across releases, so this needs to be fixed or the patch reverted before the 2.15.0 release.

[Andreas Dilger]

Hi Vitaly, Cory,
there were some defects introduced with the patch https://review.whamcloud.com/43465 "LU-14645 utils: setstripe cleanup" that need to be fixed before the 2.15 release. Could you please take a look at my (post landing) review comments on that patch.

[Andreas Dilger]

Hi Vitaly, could you please respond to the issues I posted on your patch https://review.whamcloud.com/43465 "LU-14645 utils: setstripe cleanup" and submit a patch to fix them.

[Andreas Dilger]

There are several issues with the patch that landed under this ticket that need to be fixed before the 2.15.0 release is madee.

[Peter Jones]

Landed for 2.15

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/43465/
Subject: LU-14645 utils: setstripe cleanup
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 149934fe28dac22a51ec9b2873c4f215cb204947

[Gerrit Updater]

Vitaly Fertman ([e-mail]) uploaded a new patch: https://review.whamcloud.com/43465
Subject: LU-14645 utils: setstripe cleanup
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 41e16bebbfad66ef60032f58f529e37ea4787456