Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-15821

Server driven blocking callbacks can wait behind general lru_size management

Details

    • 3
    • 9223372036854775807

    Description

      The current code places bl_ast lock callbacks at the end of the global BL callback queue.  This is bad because it causes urgent requests from the server to wait behind non-urgent cleanup tasks to keep lru_size at the right level.

      This can lead to evictions if there is a large queue of items in the global queue so the callback is not serviced in a timely manner.

      Put bl_ast callbacks on the priority queue so they do not wait behind the background traffic.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-15915 /bin/rm: fts_read failed: Cannot send after transport endpoint shutdown

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-16285 Prolong the lock BL timeout

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. LU-15822 debug in lock_matches

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Open

          Activity

            [LU-15821] Server driven blocking callbacks can wait behind general lru_size management
            sthiell Stephane Thiell added a comment -

            It would be nice to have this patch backported to 2.15.x, we have been running it for a while on 2.15.1 clients with good results.

            sthiell Stephane Thiell added a comment - It would be nice to have this patch backported to 2.15.x, we have been running it for a while on 2.15.1 clients with good results.
            gerrit Gerrit Updater added a comment -

            "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/48764
            Subject: LU-15821 ldlm: Prioritize blocking callbacks
            Project: fs/lustre-release
            Branch: b2_12
            Current Patch Set: 1
            Commit: 74666c9fff24126922e5635fbaf2394bf7eda118

            gerrit Gerrit Updater added a comment - "Andreas Dilger <adilger@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/48764 Subject: LU-15821 ldlm: Prioritize blocking callbacks Project: fs/lustre-release Branch: b2_12 Current Patch Set: 1 Commit: 74666c9fff24126922e5635fbaf2394bf7eda118
            gerrit Gerrit Updater added a comment - - edited

            "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/48122
            Subject: LU-15821 ldlm: Fix unsafe blwi access
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 97326667eb8f960fa2996099a6bd2b96496d026e
            (Patch not needed)

            gerrit Gerrit Updater added a comment - - edited "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/48122 Subject: LU-15821 ldlm: Fix unsafe blwi access Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 97326667eb8f960fa2996099a6bd2b96496d026e (Patch not needed)
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47215/
            Subject: LU-15821 ldlm: Prioritize blocking callbacks
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 2d59294d52b696125acc464e5910c893d9aef237

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47215/ Subject: LU-15821 ldlm: Prioritize blocking callbacks Project: fs/lustre-release Branch: master Current Patch Set: Commit: 2d59294d52b696125acc464e5910c893d9aef237
            gerrit Gerrit Updater added a comment -

            "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47215
            Subject: LU-15821 ldlm: Prioritize blocking callbacks
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 65a5b8d27e6d6a0acf8bc87458b8837509e60b23

            gerrit Gerrit Updater added a comment - "Patrick Farrell <pfarrell@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47215 Subject: LU-15821 ldlm: Prioritize blocking callbacks Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 65a5b8d27e6d6a0acf8bc87458b8837509e60b23

            People

              paf0186 Patrick Farrell
              paf0186 Patrick Farrell
              Votes:
              0 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: