Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-15901

mdc_changelog_cdev_init leaves freed items on the list

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.16.0
    • Lustre 2.16.0, Lustre 2.12.9, Lustre 2.15.0
    • None

    Description

              list_add_tail(&obd->u.cli.cl_chg_dev_linkage, &entry->ced_obds);
        list_add_tail(&entry->ced_link, &chlg_registered_devices);

        rc = chlg_minor_alloc(&minor);
        if (rc)
                GOTO(out_unlock, rc);
...
out_minor:
        chlg_minor_free(minor);
        list_del_init(&obd->u.cli.cl_chg_dev_linkage);
        list_del(&entry->ced_link);
out_unlock:
        mutex_unlock(&chlg_registered_dev_lock);
        if (entry)
                OBD_FREE_PTR(entry);
        RETURN(rc);

      Attachments

        Activity

          [LU-15901] mdc_changelog_cdev_init leaves freed items on the list
          cfaber Colin Faber made changes -
          Epic Link New: EX-4394 [ 67708 ]
          pjones Peter Jones made changes -
          Assignee Original: WC Triage [ wc-triage ] New: Oleg Drokin [ green ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.16

          pjones Peter Jones added a comment - Landed for 2.16
          gerrit Gerrit Updater added a comment -

          "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47480/
          Subject: LU-15901 mdc: Remove entry from list before freeing
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 441ec2296a0938dd30cf60a70943eb0799d1d70c

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/47480/ Subject: LU-15901 mdc: Remove entry from list before freeing Project: fs/lustre-release Branch: master Current Patch Set: Commit: 441ec2296a0938dd30cf60a70943eb0799d1d70c
          adilger Andreas Dilger made changes -
          Description Original: {code:java}
                  list_add_tail(&obd->u.cli.cl_chg_dev_linkage, &entry->ced_obds);
                  list_add_tail(&entry->ced_link, &chlg_registered_devices);

                  rc = chlg_minor_alloc(&minor);
                  if (rc)
                          GOTO(out_unlock, rc);
          ...
          out_minor:
                  chlg_minor_free(minor);        list_del_init(&obd->u.cli.cl_chg_dev_linkage);
                  list_del(&entry->ced_link);out_unlock:
                  mutex_unlock(&chlg_registered_dev_lock);
                  if (entry)
                          OBD_FREE_PTR(entry);
                  RETURN(rc);
           {code}           		New: {code:java}
                  list_add_tail(&obd->u.cli.cl_chg_dev_linkage, &entry->ced_obds);
                  list_add_tail(&entry->ced_link, &chlg_registered_devices);

                  rc = chlg_minor_alloc(&minor);
                  if (rc)
                          GOTO(out_unlock, rc);
          ...
          out_minor:
                  chlg_minor_free(minor);
                  list_del_init(&obd->u.cli.cl_chg_dev_linkage);
                  list_del(&entry->ced_link);
          out_unlock:
                  mutex_unlock(&chlg_registered_dev_lock);
                  if (entry)
                          OBD_FREE_PTR(entry);
                  RETURN(rc);
           {code}
          gerrit Gerrit Updater added a comment -

          "Oleg Drokin <green@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47480
          Subject: LU-15901 mdc: Remvoe entry from list before freeing
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 322e092b8412ca787c22b9edfe8b202ab9691c4c

          gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/47480 Subject: LU-15901 mdc: Remvoe entry from list before freeing Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 322e092b8412ca787c22b9edfe8b202ab9691c4c
          green Oleg Drokin created issue -

          People

            green Oleg Drokin
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: