[LU-16796] Replace LASSERT_ATOMIC_* (atomic_t) with reference counters (refcount)

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Labels: lug23dd
• Severity: 3
• Assignee: Arshad Hussain
• Reporter: Arshad Hussain

Description

 

For Example.

struct ptlrpc_sec {      
....
atomic_t ps_refcount;    
};

Which is called as...

LASSERT_ATOMIC_ZERO(&sec->ps_refcount);

Now becomes

struct ptlrpc_sec {      
....
struct kref ps_refcount;
};

and every thing should follow to support the above.

 

Currently these are under active use:

LASSERT_ATOMIC_GT
LASSERT_ATOMIC_GT_LT
LASSERT_ATOMIC_ZERO
LASSERT_ATOMIC_POS

Issue Links

• is related to: LU-18606 refcount_t warning when running sanityn/77j (refcount_t: addition on 0; use-after-free.)
• is related to: LU-9859 libcfs simplification

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56141/
Subject: LU-16796 lfsck: Change struct lfsck_tgt_desc to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d06d292abdd520709b28afbb746b9a6f9ba5321d

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56104/
Subject: LU-16796 lov: Change struct lov_stripe_md to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c3fbc7d7212a300c41a5c879ff2837e05f7f064c

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/53457/
Subject: LU-16796 lnet: Change struct lnet_delay_rule to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 661a939aa55110f50839cc15b2a5012c4ea96219

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56454
Subject: LU-16796 quota: Change struct lquota_entry to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 83738c75e4b0ac6d8f16104e21b4906c646bc342

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56453
Subject: LU-16796 obd: Change struct md_open_data to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d45cb2e84e2f1c961f4ce0cd596aa140b5b6b904

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56364
Subject: LU-16796 lfsck: Change struct ptlrpc_reply_state to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a9a5636a858cb133c32cc4f66b189620afd0a327

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56363
Subject: LU-16796 lnet: Change struct lmv_stripe_object to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4d52bbb17cbaf23eb11227c44fb276145f35212b

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/56121/
Subject: LU-16796 llite: Change struct pcc_dataset to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9a339420d903a10fdb310adc691426321637e91e

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56195
Subject: LU-16796 lfsck: Change lfsck_instance to use refcount_t
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b041d2be35331840a00c84f387011fefcf2fd0e9

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56193
Subject: LU-16796 ptlrpc: Change struct nrs_tbf_rule to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 55efd14cfb8ee62deb090797d61235c61c1c6077

[Gerrit Updater]

"Arshad Hussain <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/56177
Subject: LU-16796 lnet: Change struct lnet_ping_buffer to use kref
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2f3c4c65bab03fa2a526cb12a191b74b1ea33100