[LU-16800] Improve Lustre API error reporting

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Severity: 3
• Assignee: Alexandre Ioffe
• Reporter: Alexandre Ioffe

Description

• Add rate control of info and error messages
• Add ability to print file name/function name/line number of where from the message is sourced from
• Eliminate the split of one message on a number printfs(). Such split may cause one error message be separated on multiple distanced lines in the log in multithread application
• Fix this code:
  lustre\utils\liblustreapi.c : error_callback_default()

	/*
		 * Remove trailing linefeed so error string can be appended.
		 * @fmt is a const string, so we can't modify it directly.
		 */
		if (has_nl && (newfmt = strdup(fmt)))
			*strrchr(newfmt, '\n') = '\0';

This code trims end of line if the format has more than one '\n'

 

We can use level parameter to pass file/function/line format specifiers.

Need to review all cases of level parameter use. Review this code:

lustre\utils\liblustreapi_hsm.c :  llapi_hsm_log_error()

 

    real_level = level & LLAPI_MSG_NO_ERRNO;
    real_level = real_level > 0 ? level - LLAPI_MSG_NO_ERRNO : level;