[LU-17240] change test-framework to format and mount targets in parallel

• Type: Improvement
• Resolution: Unresolved
• Priority: Minor
• Labels: medium test_script_improvements
• Severity: 3
• Assignee: Tim Day
• Reporter: Andreas Dilger

Description

It would be useful for a number of reasons to change test-framework.sh to format and mount the MDTs and OSTs in parallel (if not both MDTs and OSTs at the same time, then at least in two sets).

• this would reduce testing time significantly for tests that reformat the filesystem (e.g. conf-sanity)
• this would improve testing of the MGS to handle registering multiple targets in parallel (there are at least some known issues with this that could be found and fixed)
• this would improve test coverage since filesystems are often mounted in parallel in production, and this would better simulate the real world

Issue Links

• is related to: LU-4966 MGS target registration should use proper UUID
• is related to: LU-15112 attempt to register an OST with duplicated index should fail but it does not
• is related to: LU-14928 Allow MD target re-registered after writeconf

Comments

[Alex Zhuravlev]

I've modified patch slightly so it runs locally as well: https://review.whamcloud.com/c/fs/lustre-release/+/59296
and tested few different combinations: ldiskfs/zfs, parallel ost, mdt+ost, none:
https://testing.whamcloud.com/test_sessions/related?jobs=lustre-reviews&builds=113556#redirect
the tests were limited to subtests 0-5 to get a feedback quickly.
I don't see a visible improvement for a reason, thought the logs confirm concurrent mkfs where it was requested.
will check the details a bit later.

[Alex Zhuravlev]

at least locally it breaks multiple tests right away, will check the details.

[Andreas Dilger]

Tim already pushed a patch for this.

[Gerrit Updater]

"Timothy Day <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/53518
Subject: LU-17240 tests: format and mount targets in parallel
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e2ea758f0a11cef20621759746750ac92de418af

[Andreas Dilger]

The other ones are patch https://review.whamcloud.com/45259 "LU-15112 mgc: do not ignore target registration failure" and maybe patch https://review.whamcloud.com/45871 "LU-15112 ptlrpc: make rq_replied flag always correct" included in 2.14.57.

[Andreas Dilger]

Tim, it looks like the patch I was thinking about is https://review.whamcloud.com/44594 "LU-14928 mgs: allow md target re-register" and that has been landed since 2.14.55. That at least addresses part of the issue, though I thought there was at least one more patch in this area about re-registering targets.

[Alexey Lyashkov]

Andreas,

it's Zam patch I think. I have just move all handling in single thread.
as about ticket..
I don't think it's large problem - as test target is small and format rate, except a conf-sanity.