[LU-17587] lustre-client dkms build is partially broken

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.16.0, Lustre 2.15.5
• Severity: 3
• Assignee: Shane Nehring
• Reporter: Shane Nehring

Description

The dkms build for lustre-client is partially broken. It will always build the module against the running version of the kernel, not the version specified by dkms. The fix seems to be pretty easy:

diff --git a/lustre-dkms_pre-build.sh b/lustre-dkms_pre-build.sh
index ce298cb763..54f9cc40af 100755
--- a/lustre-dkms_pre-build.sh
+++ b/lustre-dkms_pre-build.sh
@@ -22,7 +22,7 @@
 case $1 in
     lustre-client)
        SERVER="--disable-server"
-       KERNEL_STUFF=""
+       KERNEL_STUFF="--with-linux=$4 --with-linux-obj=$4"
        ;;
 
     lustre-zfs|lustre-all)

Comments

[Gerrit Updater]

"Oleg Drokin <[e-mail]>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54830/
Subject: LU-17587 build: use kernel version from dkms for client
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aa76ae0c21a7e315ecb1fded82f2c793aa26f78c

[Peter Jones]

By all means you could push it to b2_15 also but it would probably be best to finalize the patch on master before doing so.

[Shane Nehring]

If I wanted this to get into the next 2_15 release should I also push that to b2_15 or would that normally get sorted via another process after this change is accepted into master?

[Gerrit Updater]

"snehring <[e-mail]>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54830
Subject: LU-17587 build: use kernel version from dkms for client
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2d217a710b5ae005a2ebb85eb5594e8acdefdca4

[Andreas Dilger]

Shane, I've raised an issue with the appropriate people to get that working again. Thanks for pointing it out.

[Shane Nehring]

I did try that, but the google oauth2 option seems to be broken. It complains about a redirect_uri mismatch.

[Andreas Dilger]

snehring, to create an account in Gerrit you need an OAuth2 provider. Using a gmail account is probably the easiest way to do this.

[Jian Yu]

Hi snehring,
FYI: https://wiki.lustre.org/Using_Gerrit

[Shane Nehring]

I was originally but I couldn't quite suss out how to login/register with Gerrit. Definitely could if I figure that out.

[Andreas Dilger]

Shane, were you planning on pushing a patch for this yourself, accompanied by the fame and glory that results , or were you just reporting it and wanted someone else to do that?