Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-17602

mdd_rename's error handling can break namespace

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.16.0
    • Lustre 2.14.0, Lustre 2.16.0
    • None
    • 3
    • 9223372036854775807

    Description

      			rc2 = __mdd_index_insert(env, mdd_tpobj, tpobj_fid,
						 mdd_object_type(mdd_tobj),
						 tname, handle);

      i.e. mdd_rename() can insert tname pointing to own FID.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-17016 rename across projects incorrectly checks source parent directory

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-17602] mdd_rename's error handling can break namespace
            pjones Peter Jones made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones added a comment -

            Landed for 2.16

            pjones Peter Jones added a comment - Landed for 2.16
            gerrit Gerrit Updater added a comment -

            "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54260/
            Subject: LU-17602 mdd: use correct fid in mdd_rename
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 941c0205d127082fc98d3827037cd9a21e1e29a9

            gerrit Gerrit Updater added a comment - "Oleg Drokin <green@whamcloud.com>" merged in patch https://review.whamcloud.com/c/fs/lustre-release/+/54260/ Subject: LU-17602 mdd: use correct fid in mdd_rename Project: fs/lustre-release Branch: master Current Patch Set: Commit: 941c0205d127082fc98d3827037cd9a21e1e29a9
            adilger Andreas Dilger added a comment -

            Alex, thanks for finding this. Looks like it was my mistake with these variable names that are very similar.

            adilger Andreas Dilger added a comment - Alex, thanks for finding this. Looks like it was my mistake with these variable names that are very similar.
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-17016 [ LU-17016 ]
            adilger Andreas Dilger made changes -
            Affects Version/s New: Lustre 2.14.0 [ 14490 ]
            Affects Version/s New: Lustre 2.16.0 [ 15190 ]
            adilger Andreas Dilger made changes -
            Fix Version/s New: Lustre 2.16.0 [ 15190 ]
            adilger Andreas Dilger made changes -
            Priority Original: Minor [ 4 ] New: Critical [ 2 ]
            pjones Peter Jones made changes -
            Assignee Original: WC Triage [ wc-triage ] New: Alex Zhuravlev [ bzzz ]
            gerrit Gerrit Updater added a comment -

            "Alex Zhuravlev <bzzz@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54260
            Subject: LU-17602 mdd: use correct fid in mdd_rename
            Project: fs/lustre-release
            Branch: master
            Current Patch Set: 1
            Commit: 5f11651115e5a5ff88195894ee4d7202829e3dd0

            gerrit Gerrit Updater added a comment - "Alex Zhuravlev <bzzz@whamcloud.com>" uploaded a new patch: https://review.whamcloud.com/c/fs/lustre-release/+/54260 Subject: LU-17602 mdd: use correct fid in mdd_rename Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 5f11651115e5a5ff88195894ee4d7202829e3dd0

            People

              bzzz Alex Zhuravlev
              bzzz Alex Zhuravlev
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: