Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-3159

proc filenames are broken in pre-2.4

Details

    • Bug
    • Resolution: Fixed
    • Blocker
    • Lustre 2.4.0
    • Lustre 2.4.0
    • 3
    • 7666

    Description

      The proc directory naming of the filter-* namespaces is pretty broken on master. In 2.1, it would look like this:

      /proc/fs/lustre/ldlm/namespaces/filter-lsa-OST0000_UUID

      but as of 2.3.63 it not looks like this:

      /proc/fs/lustre/ldlm/namespaces/filter-ffff88081233c000

      The previous form was human readable, and tools could relatively easily match those stats up with the correct OST, because the OST name is right in the directory name. The new form is not human readable, and I can't find any mention of that pointer value anywhere else in /proc, so it is pretty useless.

      Not to mention is is very likely a bad idea security wise to be exposing internal kernel pointer values to user-space like this.

      Since LMT is currently the only way that our admins have the slightest idea what is going on with a Lustre filesystem and this significantly degrades LMT's functionality, I would argue that this needs to be fixed before 2.4.0.

      Attachments

        Activity

          [LU-3159] proc filenames are broken in pre-2.4
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.4.0 [ 10154 ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.4

          pjones Peter Jones added a comment - Landed for 2.4
          jlevi Jodi Levi (Inactive) made changes -
          Labels New: LB
          Priority Original: Major [ 3 ] New: Blocker [ 1 ]
          yujian Jian Yu made changes -
          Affects Version/s New: Lustre 2.4.0 [ 10154 ]
          yujian Jian Yu added a comment -

          Patch for Lustre master branch is in http://review.whamcloud.com/6039.

          yujian Jian Yu added a comment - Patch for Lustre master branch is in http://review.whamcloud.com/6039 .
          yujian Jian Yu made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          pjones Peter Jones made changes -
          Assignee Original: WC Triage [ wc-triage ] New: Jian Yu [ yujian ]
          pjones Peter Jones added a comment -

          Yu, Jian

          Could you please do as Andreas suggests to address this one?

          Thanks

          Peter

          pjones Peter Jones added a comment - Yu, Jian Could you please do as Andreas suggests to address this one? Thanks Peter
          adilger Andreas Dilger added a comment -

          The LDLM namespace naming was fixed (along with some other things) in my patch at http://review.whamcloud.com/4618. I'd be happy if someone extracted those changes out of my patch and landed them for 2.4.0.

          adilger Andreas Dilger added a comment - The LDLM namespace naming was fixed (along with some other things) in my patch at http://review.whamcloud.com/4618 . I'd be happy if someone extracted those changes out of my patch and landed them for 2.4.0.
          morrone Christopher Morrone (Inactive) created issue -

          People

            yujian Jian Yu
            morrone Christopher Morrone (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: