[LU-5296] lod_attr_set() skips attr_set on osp objects incorrectly

• Type: Bug
• Resolution: Fixed
• Priority: Critical
• Fix Version/s: Lustre 2.6.0
• Affects Version/s: Lustre 2.6.0
• Labels: HB
• Severity: 3
• Assignee: Niu Yawei (Inactive)
• Reporter: Niu Yawei (Inactive)

Description

This is a regression introduced by fix of LU-4690 "lod: separate master object with master stripe" (http://review.whamcloud.com/9511 commit 60e07b972114df24105a3a1bfa7365892f72a4a7).

In lod_attr_set():

        for (i = 0; i < lo->ldo_stripenr; i++) {
                LASSERT(lo->ldo_stripe[i]);
+               if (dt_object_exists(lo->ldo_stripe[i]) == 0)
+                       continue;
                rc = dt_attr_set(env, lo->ldo_stripe[i], attr, handle, capa);
                if (rc) {
                        CERROR("failed declaration: %d\n", rc);

Since dt_object_exists() always return false for the osp object (for OST object), any attr_set to osp object will be skipped mistakenly, and chown/chgrp won't set UID/GID to OST objects at the end.

As per Di's suggestion, we'd add additional IS_DIR checking here.

Issue Links

• is related to: LU-4515 Test failure sanity-quota test_34: Used space for user 60000 is 0, expected 2048
• is related to: LU-4690 sanity test_4: Expect error removing in-use dir /mnt/lustre/remote_dir

Comments

[Andreas Dilger]

What is the impact of this bug? Does it mean that quota will be incorrect during normal usage? Is it causing test failures?

[Andreas Dilger]

How does this relate to LU-5006 "chown/chgrp doesn't work for files created by lfs setstripe"?

[Niu Yawei (Inactive)]

then it's probably better remove this check from LOD ?

I think DNE relies on that check for dir object. Di, any comment on this? Thanks.

[Alex Zhuravlev]

then it's probably better remove this check from LOD ?

[Niu Yawei (Inactive)]

Actually, current osp thread can't handle exceptions gracefully, I opened another ticket to track the problem there. See LU-5297.

[Niu Yawei (Inactive)]

http://review.whamcloud.com/10989