Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-5296

lod_attr_set() skips attr_set on osp objects incorrectly

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.6.0
    • Lustre 2.6.0
    • 3
    • 14780

    Description

      This is a regression introduced by fix of LU-4690 "lod: separate master object with master stripe" (http://review.whamcloud.com/9511 commit 60e07b972114df24105a3a1bfa7365892f72a4a7).

      In lod_attr_set():

              for (i = 0; i < lo->ldo_stripenr; i++) {
                LASSERT(lo->ldo_stripe[i]);
+               if (dt_object_exists(lo->ldo_stripe[i]) == 0)
+                       continue;
                rc = dt_attr_set(env, lo->ldo_stripe[i], attr, handle, capa);
                if (rc) {
                        CERROR("failed declaration: %d\n", rc);

      Since dt_object_exists() always return false for the osp object (for OST object), any attr_set to osp object will be skipped mistakenly, and chown/chgrp won't set UID/GID to OST objects at the end.

      As per Di's suggestion, we'd add additional IS_DIR checking here.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-4515 Test failure sanity-quota test_34: Used space for user 60000 is 0, expected 2048

          • Major - Major loss of function.
          • Resolved
          is related to

          Bug - A problem which impairs or prevents the functions of the product. LU-4690 sanity test_4: Expect error removing in-use dir /mnt/lustre/remote_dir

          • Blocker - Blocks development and/or testing work, production could not run.
          • Resolved

          Activity

            [LU-5296] lod_attr_set() skips attr_set on osp objects incorrectly
            adilger Andreas Dilger made changes -
            Labels Original: HB always_except New: HB
            jlevi Jodi Levi (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            pjones Peter Jones made changes -
            Link New: This issue is related to ATP-4 [ ATP-4 ]
            adilger Andreas Dilger made changes -
            Labels New: HB always_except
            adilger Andreas Dilger made changes -
            Priority Original: Major [ 3 ] New: Critical [ 2 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-4515 [ LU-4515 ]
            adilger Andreas Dilger made changes -
            Priority Original: Critical [ 2 ] New: Major [ 3 ]
            adilger Andreas Dilger made changes -
            Fix Version/s New: Lustre 2.6.0 [ 10595 ]
            adilger Andreas Dilger made changes -
            Priority Original: Major [ 3 ] New: Critical [ 2 ]
            adilger Andreas Dilger made changes -
            Description Original: This is a regression introduced by fix of LU-4690.

            In lod_attr_set():
            {code}
                    for (i = 0; i < lo->ldo_stripenr; i++) {
                            LASSERT(lo->ldo_stripe[i]);
            + if (dt_object_exists(lo->ldo_stripe[i]) == 0)
            + continue;
                            rc = dt_attr_set(env, lo->ldo_stripe[i], attr, handle, capa);
                            if (rc) {
                                    CERROR("failed declaration: %d\n", rc);
            {code}
            Since dt_object_exists() always return false for the osp object (for OST object), any attr_set to osp object will be skipped mistakenly, and chown/chgrp won't set UID/GID to OST objects at the end.

            As per Di's suggestion, we'd add additional IS_DIR checking here.             		New: This is a regression introduced by fix of [LU-4690 "lod: separate master object with master stripe"|LU-4690] (http://review.whamcloud.com/9511 commit 60e07b972114df24105a3a1bfa7365892f72a4a7).

            In lod_attr_set():
            {code}
                    for (i = 0; i < lo->ldo_stripenr; i++) {
                            LASSERT(lo->ldo_stripe[i]);
            + if (dt_object_exists(lo->ldo_stripe[i]) == 0)
            + continue;
                            rc = dt_attr_set(env, lo->ldo_stripe[i], attr, handle, capa);
                            if (rc) {
                                    CERROR("failed declaration: %d\n", rc);
            {code}
            Since dt_object_exists() always return false for the osp object (for OST object), any attr_set to osp object will be skipped mistakenly, and chown/chgrp won't set UID/GID to OST objects at the end.

            As per Di's suggestion, we'd add additional IS_DIR checking here.

            People

              niu Niu Yawei (Inactive)
              niu Niu Yawei (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: