[LU-5493] New static analysis issues in 2.6.50-112-g01def2b

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.7.0
• Labels: kw
• Severity: 3
• Assignee: WC Triage
• Reporter: Dmitry Eremin (Inactive)

Description

Found 2 new static analysis issues in 2.6.50-112-g01def2b:

1. Result of function that can return NULL may be dereferenced
   • lnet/lnet/api-ni.c: in LNetNIInit, Pointer 'nets' returned from call to function 'lnet_get_networks' at line 1779 may be NULL and may be dereferenced at line 1785.
     TRACEBACK
     api-ni.c:1779: 'nets' is assigned the return value from function 'lnet_get_networks'.
     api-ni.c:85: 'lnet_get_networks' explicitly returns a NULL value.
     api-ni.c:1785: 'nets' is dereferenced by passing argument 2 to function 'lnet_parse_networks'.
     config.c:197: 'networks' is passed to function 'lnet_parse_networks'.
     config.c:200: 'networks' is dereferenced by passing argument 1 to function 'strlen'.

1. Joining with binary operator does not respect strong typing
   • lnet/lnet/api-ni.c: in lnet_ping_info_install_locked, A strongly typed value of type '__u32' is compared with a value of a different type 'int'

The list of commits since the previous build 2.6.50-106-g9593c98:

01def2b	LU-2675 build: remove Darwin "support"
92c5184	LU-2456 lnet: DLC Feature dynamic net config
18ad797	LU-5418 libcfs: only define noop_*_fn when readline is used
c079e8c	LU-2456 lnet: Dynamic LNet Configuration (DLC) dynamic routing
d018343	LU-5476 llite: Fix integer overflow in ll_fid2path
94d923d	LU-4423 obdecho: bitwise vs logical typo

Issue Links

• is related to: LU-5540 crash in lnet_parse_networks
• is related to: LU-4629 Issues found by static analysis tools

Comments

[Dmitry Eremin (Inactive)]

Fixed by http://review.whamcloud.com/#/c/11626/5