[LU-6502] Strange check for NULL in LNetCtl

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.8.0
• Severity: 3
• Assignee: Amir Shehata (Inactive)
• Reporter: Oleg Drokin

Description

smatch highlights this interesting bit of code in LNetCtl:

                config = arg;

                if (config->cfg_hdr.ioc_len < total)
                        return -EINVAL;

                net_config = (struct lnet_ioctl_net_config *)
                        config->cfg_bulk;
                if (config == NULL || net_config == NULL)
                        return -1;

notic how we assume config can be NULL way after we defererenced it multiple times. should we move the check?