Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.8.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      smatch highlights this interesting bit of code in LNetCtl:

                      config = arg;
      
                      if (config->cfg_hdr.ioc_len < total)
                              return -EINVAL;
      
                      net_config = (struct lnet_ioctl_net_config *)
                              config->cfg_bulk;
                      if (config == NULL || net_config == NULL)
                              return -1;
      

      notic how we assume config can be NULL way after we defererenced it multiple times. should we move the check?

      Attachments

        Activity

          [LU-6502] Strange check for NULL in LNetCtl
          pjones Peter Jones added a comment -

          Landed for 2.8

          pjones Peter Jones added a comment - Landed for 2.8

          Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15779/
          Subject: LU-6502 lnet: remove unnecessary NULL check
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 5ebe1b768e7c8397036c94ca43848067269dbf50

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/15779/ Subject: LU-6502 lnet: remove unnecessary NULL check Project: fs/lustre-release Branch: master Current Patch Set: Commit: 5ebe1b768e7c8397036c94ca43848067269dbf50

          Amir Shehata (amir.shehata@intel.com) uploaded a new patch: http://review.whamcloud.com/15779
          Subject: LU-6502 lnet: remove unnecessary NULL check
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 21f4374fab33579b2a5f3ed06975826ff4951b1d

          gerrit Gerrit Updater added a comment - Amir Shehata (amir.shehata@intel.com) uploaded a new patch: http://review.whamcloud.com/15779 Subject: LU-6502 lnet: remove unnecessary NULL check Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 21f4374fab33579b2a5f3ed06975826ff4951b1d

          People

            ashehata Amir Shehata (Inactive)
            green Oleg Drokin
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: