[LU-6539] incorrect integer format string used for short type

• Type: Bug
• Resolution: Fixed
• Priority: Trivial
• Fix Version/s: Lustre 2.8.0
• Affects Version/s: Lustre 2.7.0
• Environment: Build on Ubuntu 15.04, static analysis check build with current cppcheck
• Severity: 4
• Assignee: Dmitry Eremin (Inactive)
• Reporter: Colin Ian King

Description

cppcheck found an incorrect format string being used for a short type:

Checking lustre/quota/lquota_entry.c...
[lustre/quota/lquota_entry.c:219]: (warning) %u in format string (no. 1) requires 'unsigned int' but the argument type is 'short'.

struct lquota_site *lquota_site_alloc(const struct lu_env *env, void *parent,
bool is_master, short qtype,
struct lquota_entry_operations *ops)
...

sprintf(hashname, "LQUOTA_HASH%u", qtype);

needs to be %hu (or %hd)