[LU-7699] Overhaul lustre's versioning

• Type: Technical task
• Resolution: Done
• Priority: Critical
• Fix Version/s: Lustre 2.9.0
• Assignee: Christopher Morrone (Inactive)
• Reporter: Christopher Morrone (Inactive)

Description

There are numerous oddities about Lustre's system for applying version numbers in the configuration and packaging system. At this point, it is looking strongly like an overhaul is in order.

Issue Links

• is blocking: LU-7642 Allow lustre source build without git working directory
• is blocking: LU-7643 Remove kernel version string from Lustre release field
• is blocking: LU-7645 Stop controlling the RPM Release field from Lustre's build system
• is related to: LU-7976 sles builds severely impacted by recent naming changes
• is related to: LU-474 fix release build issues

Comments

[Christopher Morrone (Inactive)]

It is now just three patches:

• http://review.whamcloud.com/18107
• http://review.whamcloud.com/18108
• http://review.whamcloud.com/18111

[Christopher Morrone (Inactive)]

OK, I think I'm ready for the first round of reviews on the current four patches:

• http://review.whamcloud.com/18107
• http://review.whamcloud.com/18108
• http://review.whamcloud.com/18110
• http://review.whamcloud.com/18111

[Gerrit Updater]

Christopher J. Morrone ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18112
Subject: LU-7699 build: debug intel buildfarm
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 073eb66d36756f2f498d4c9aceb982a25c97e364

[Gerrit Updater]

Christopher J. Morrone ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18111
Subject: LU-7699 build: Remove unnecessary AC_LUSTRE_

{MAJOR,MINOR,PATCH,FIX}

Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b28a363a54d2b45a8f64b6ec81f0d0abedc220f7

[Gerrit Updater]

Christopher J. Morrone ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18110
Subject: LU-7699 build: Replace LUSTRE_VERSION_STRING with PACKAGE_VERSION
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 4ace235aef94e2182bc62a28e5cdb479ac3c2fcb

[Gerrit Updater]

Christopher J. Morrone ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18108
Subject: LU-7699 build: Eliminate lustre_build_version.h
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 49e8ccfea6d6845ca13e9a2dd8d0a5635c9bc8c0

[Christopher Morrone (Inactive)]

Two more revisions to fix easy problems. The first major issue is now what I expected: I need to teach lbuild about the new versioning scheme.

It also looks like the ppc64 builder isn't happy either. I'm not sure that it provides enough information to do anything about it though...maybe I can make a good enough guess to get it working.

But that will all have to wait until next week.

[Christopher Morrone (Inactive)]

I have a first rough version of the first overhaul patch. It is a net reduction in almost 300 lines, so I must be doing something right.

I think the patch is already decent, but I haven't really considered how lbuild is going to react to the changes, or looked at how the rpm or dpkg packaging systems are going to handle it. It may need further work to get along with all of that. But it is worth running this version through the build farm as a fortestonly patch to see what blows up first.

There is quite a bit of additional cleanup that can be done, but I want to try to avoid putting too much change in one patch. I'll add additional cleanup in a follow-on patch.

Some things that I'll look into (just so I don't forget):

• Get rid of lustre_build_version.h
• Fix how Lustre embeds the version into its binaries
• Further cleanup autoconf variables and m4 macros pertaining to versioning that are no longer necessary if we use standard ones like {AC_}

  PACKAGE_VERSION

• git grep for "META" and deal with its obsolescence

[Gerrit Updater]

Christopher J. Morrone ([e-mail]) uploaded a new patch: http://review.whamcloud.com/18107
Subject: LU-7699 build: Replace version_tag.pl with LUSTRE-VERSION-GEN
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: e0a4a49958df15608615533c1e6f67bf3aca9f26

[Christopher Morrone (Inactive)]

Why do we have both lustre_ver.h and lustre_build_version.h? So silly.