Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-7729

Don't return ptlrpc_error() in process_req_last_xid().

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • Lustre 2.8.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      process_req_last_xid():

                     if (!(lustre_msg_get_flags(req->rq_reqmsg) & MSG_REPLAY)) {
                       req->rq_status = -EPROTO;
                       RETURN(ptlrpc_error(req));
               }

      This will return 0 to caller mistakenly.

      Attachments

        Issue Links

          is related to

          New Feature - A new feature of the product, which has yet to be developed. LU-5319 Support multiple slots per client in last_rcvd file

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved

          Activity

            [LU-7729] Don't return ptlrpc_error() in process_req_last_xid().
            adilger Andreas Dilger made changes -
            Link Original: This issue is related to LU-4039 [ LU-4039 ]
            adilger Andreas Dilger made changes -
            Link New: This issue is related to LU-4039 [ LU-4039 ]
            jgmitter Joseph Gmitter (Inactive) made changes -
            Link Original: This issue is related to LDEV-36 [ LDEV-36 ]
            jgmitter Joseph Gmitter (Inactive) made changes -
            Link New: This issue is related to LDEV-37 [ LDEV-37 ]
            jgmitter Joseph Gmitter (Inactive) made changes -
            Resolution New: Fixed [ 1 ]
            Status Original: Open [ 1 ] New: Resolved [ 5 ]
            jgmitter Joseph Gmitter (Inactive) added a comment -

            Patch has landed for 2.8

            jgmitter Joseph Gmitter (Inactive) added a comment - Patch has landed for 2.8
            gerrit Gerrit Updater added a comment -

            Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18245/
            Subject: LU-7729 target: fix process_req_last_xid() return value
            Project: fs/lustre-release
            Branch: master
            Current Patch Set:
            Commit: 8867e6138c228cce89b94fb9415a2557f8e43ad6

            gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch http://review.whamcloud.com/18245/ Subject: LU-7729 target: fix process_req_last_xid() return value Project: fs/lustre-release Branch: master Current Patch Set: Commit: 8867e6138c228cce89b94fb9415a2557f8e43ad6
            pichong Gregoire Pichon made changes -
            Link New: This issue is related to LU-5319 [ LU-5319 ]
            yujian Jian Yu made changes -
            Link New: This issue is related to LDEV-36 [ LDEV-36 ]
            pjones Peter Jones made changes -
            Priority Original: Minor [ 4 ] New: Critical [ 2 ]

            People

              niu Niu Yawei (Inactive)
              niu Niu Yawei (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: