[LU-8360] obd_set_info_async error suppressed

• Type: Bug
• Resolution: Fixed
• Priority: Minor
• Fix Version/s: Lustre 2.9.0
• Severity: 3
• Assignee: Yang Sheng
• Reporter: Yang Sheng

Description

This bug is reported by Seagate:
lustre-wc-rel/lustre/llite/llite_lib.c:

static int client_common_fill_super(struct super_block *sb, char *md, char *dt,
                                    struct vfsmount *mnt)
{
...
        checksum = sbi->ll_flags & LL_SBI_CHECKSUM;
        err = obd_set_info_async(NULL, sbi->ll_dt_exp, sizeof(KEY_CHECKSUM),
                                 KEY_CHECKSUM, sizeof(checksum), &checksum,
                                 NULL);
        cl_sb_init(sb);

        err = obd_set_info_async(NULL, sbi->ll_dt_exp, sizeof(KEY_CACHE_SET),<--- Variable 'err' is reassigned a value before the old one has been used.
                                 KEY_CACHE_SET, sizeof(*sbi->ll_cache),
                                 sbi->ll_cache, NULL);

        sb->s_root = d_make_root(root);
        if (sb->s_root == NULL) {
                CERROR("%s: can't make root dentry\n",
                        ll_get_fsname(sb, NULL, 0));
                GOTO(out_root, err = -ENOMEM);
        }
...

This ticket want to trace patch landed to master.