Details
-
Bug
-
Resolution: Fixed
-
Major
-
None
-
Lustre 2.5.3
-
None
-
TOSS 2.4-9
-
2
-
9223372036854775807
Description
After a power outage we encountered a hardware error on one of our storage devices that essentially corrupted ~30 files on one of the OSTs. Since then the OST has been read-only and is throwing the following log messages:
[ 351.029519] LustreError: 8974:0:(ofd_obd.c:1376:ofd_create()) fscratch-OST0001: unable to precreate: rc = -5
[ 360.762505] LustreError: 8963:0:(ofd_obd.c:1376:ofd_create()) fscratch-OST0001: unable to precreate: rc = -5
[ 370.784372] LustreError: 8974:0:(ofd_obd.c:1376:ofd_create()) fscratch-OST0001: unable to precreate: rc = -5
I have scrubbed the device in question and rebooted the system bring up the server normally but I am still unable to create a file on that OST.
zpool status -v reports the damaged files and recommended restoring from backup and I'm inclined to simply removing the files. I know how to do this with ldiskfs but I don't know how to with ZFS. At this point I don't know how to proceed.
Attachments
Issue Links
- is related to
-
LU-7585 Implement OI Scrub for ZFS
-
- Resolved
-
Activity
With ldiskfs it is relatively safe to mount the MDT as type ldiskfs and collect read-only data from the filesystem. The local MDT data will not contain file sizes, only filenames, owners, timestamps, etc. We don't test this mode officially, but I use it to poke around in my home filesystem, though that filesystem has very low activity. It is not possible to do this with ZFS.
How many OSTs do you have? I would think if there is currently 71% free space in the filesystem, and you have more than 10-12 OSTs (each 70% full), then removing one of them would only increase space usage by 6-7% or less on the remaining OSTs, which should still be OK? I'd suspect that the OST in question itself already has less than 70% usage because it can delete files but not create new ones, so it may be less data that needs to be migrated.
I've circled back to this issue and since we are unable to repair the target our only option is to either migrate the files on the read only target to other OSTs or punt. One of the problems we have at the moment is that the capacity of the file system is at ~71% and as a result migration is problematic.
We concluded that the best course of action would be to purge older data from the file system to free up space and tried using lfs find to gather file stats. Unfortunately, this method has to be abandoned because of the ~1400 top level directories we have only been able to collect data on roughly 300 of those directories in the course of a month.
I was playing around on one of my test file systems and discovered that I can get all the data I want from the MDT (i.e., create, modify and access timestamps) by mounting the MDT ldiskfs and running stat on the files in /ROOT/O. My question is, would it be prudent to take a system outage to collect this data or am I safe having the device mounted both lustre and ldiskfs (read only) at the same time?
Thanks in advance.
I've circled back to this issue and since we are unable to repair the target our only option is to either migrate the files on the read only target to other OSTs or punt. One of the problems we have at the moment is that the capacity of the file system is at ~71% and as a result migration is problematic.
We concluded that the best course of action would be to purge older data from the file system to free up space and tried using lfs find to gather file stats. Unfortunately, this method has to be abandoned because of the ~1400 top level directories we have only been able to collect data on roughly 300 of those directories in the course of a month.
I was playing around on one of my test file systems and discovered that I can get all the data I want from the MDT (i.e., create, modify and access timestamps) by mounting the MDT ldiskfs and running stat on the files in /ROOT/O. My question is, would it be prudent to take a system outage to collect this data or am I safe having the device mounted both lustre and ldiskfs (read only) at the same time?
Thanks in advance.
Besides the OI scrub to repair the corruption in the ZFS filesystem, I think the only other option is to migrate the files off this OST onto other OSTs and then reformat it. How much space this will consume on the other OSTs depends on how many OSTs there are.
That isn't a great solution, but the repair tools for ZFS are somewhat less robust than for ldiskfs since ZFS itself doesn't get corrupted very easily. Once the OI Scrub functionality is available for ZFS we will be able to repair a fair amount of corruption in the backing filesystem, though it still wouldn't be possible to recover the user data in any OST objects that were corrupted.
What others can we do for this ticket in addition to the on-going ZFS OI scrub?
I will work on LU-7585 to implement ZFS OI scrub, that will allow us to rebuild "/O" directory on the OST. On some degree, such functionality may be helpful for this issue. But the OI scrub can rebuild the OI mappings, it cannot repair the corrupted data. If related objects themselves corrupted (quite possible), not (only) related entries missed from the "/O" tree. Then ZFS OI scrub cannot help much. Anyway, such work will not be ready in short time, so your current solution is quite necessary.
OK, so it is good news at least that the OST is currently mounted and readable, and not totally offline. I assume you do not have a snapshot of the OST that would allow recovery, and it has likely been online long enough that the old uberblocks which might reference an uncorrupted version of the filesystem have been overwritten (there are only 256, and they are updated at 1s intervals).
Note that deactivating the OST on the MDS will prevent the OST objects from being deleted due to LU-4295, but that may a benefit if the OST is corrupt and deleting files may cause more problems, and also not an issue if you would be draining the whole OST and reformatting it. Since the OST can't precreate objects it may be that marking it deactivated on the MDS is redundant, but not otherwise harmful.
Andreas - Yes, you are correct with regard to both configurations and we were pretty much discussing the same things here. We have kicked around the idea of perhaps trying to migrate the data on the bad OST but then the file system is at >76% full and we start running into problems when it approaches 80% so that is problematic.
As it turns out, even if I try force a file to be created on that OST via lfs setstripe -i 1 it will bounce it to a different OST. I have been able to access files on that OST identifying them with lfs find and can at least read/delete and actually modify existing files that I have examined in my own directory space (the write operation took some time but it surprisingly completed.) I have deactivated the OST in the meantime.
I look forward to any additional feedback or suggestions. Thanks Andreas
Fan Yong - Thanks for the info.
I did some examination of ZFS OSTs on a working test file system and I could not find a LAST_ID anywhere. Is it supposed to exist under ZFS?
The "LAST_ID" for ldiskfs backend is named as "LAST_ID" under "/O/<seq>" directory. For ZFS backend, it is named as "0" under "/O/<seq>/d0" directory.
Ah, so there is a single RAID LUN == VDEV per zpool? That would mean that the ZFS-level metadata redundancy (ditto blocks) would all go to the same LUN, and if that LUN becomes corrupted there is a high likelihood that the ditto copy on the same LUN would also be corrupted, unlike the common ZFS case where the ditto copy is on a separate LUN/VDEV.
My understanding is that the ZFS configuration on LLNL Sequoia has 3 separate RAID LUNs (each one a separate VDEV) so that the ditto copies (2 or 3 copies depending on what metadata it is) are at least on separate devices. In that case, the corruption of one RAID LUN might cause corruption of regular file data, but the ZFS and Lustre metadata would survive.
As for moving forward with this problem, I can discuss with Fan Yong whether it is possible to implement the ability for LFSCK to fix the O/0/d* directories on ZFS during the OST object traversal. This would not necessarily be a quick fix, but might be worthwhile to wait for if the data on this OST is critical. In the meantime, it may be possible to deactivate the OST on the MDS (lctl --device %fscratch-OST0001-osc-MDT0000 deactivate) so that it doesn't try to do the object precreate, and then mount the OST to at least make it available in a read-only mode to clients. There will still be I/O errors because at least 6 of 32 OST object directories are reporting errors and there may be problems doing object lookups, but it may also be that only a few blocks in each directory is bad and the OST may be mostly usable to get read access to files stored there. Since the OST is deactivated on the MDS then new files will not be created there.
For a given Lustre striped regular file, its attributes are distributed to several targets (MDT and OSTs). The filename, owner, mode and permission are stored on the MDT. Each stripe (or OST-object) stores its own size/blocks attribute, client needs to calculate the file size/blocks attribute by sum all related OST-objects' size/blocks attributes. As for the xtime (atime, mtime, ctime) attribute, both the MDT-object and OST-objects store the timestamp. Which one will be used as the file xtime, depends on which ctime is newer.
So directly mount the target as backend filesystem, in spite of "ldiskfs" or "ZFS", you can NOT directly get the file size and xtime attributes. But you can calculate those attributes. For a given OST-object, you can get its MDT-object's FID from the OST-object's PFID EA, the OST-objects with the same MDT-object's FID belong to the same file. Then you can sum related OST-objects' size, and also compare their ctime. So you can get the file's size/time attributes. But consider such process, I am not sure whether it is really more efficient than directly collecting the information from Lustre client.