[LU-871] clang: minor code cleanups - Whamcloud Community JIRA

Details

Type: Technical task
Resolution: Fixed
Priority: Minor
Fix Version/s: Lustre 2.2.0
Affects Version/s: Lustre 2.2.0
Labels:
- clang
Environment:
FC13 running clang-analyzer-2.8-10.fc13.x86_64

Rank (Obsolete):
4812

Description

Tracking bug for warnings produced by the clang-analyzer static code analysis tool.

The first one is a trivial printk() format warning due to the use of "%Lu" for LPU64, and other places in the code. The "%L" format specifier is a GCCism that is deprecated in favor of "%ll" from C99.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending
- Thumbnails
- List
- Download All

lustre-2.1.54-scan-build_wo_core.NullDereference_check.tar.bz2
5.47 MB
12/Jan/12 7:47 AM

Issue Links

is related to

LU-2675 clang: code cleanups for sparse static analyzer

Resolved

Trackbacks

Changelog 2.2 version 2.2.0 Support for networks: o2iblnd OFED 1.5.4 Server support for kernels: 2.6.32220.4.2.el6 (RHEL6) Client support for unpatched kernels: 2.6.18274.18.1.el5 (RHEL5) 2.6.32220.4.2.el6 (RHEL6) 2.6.32.360....

Project Ideas Information for Developers Working on Lustre will quickly introduce a developer to the always interesting and impressive world of HPC, where the systems are the largest in the world,...

Activity

[LU-871] clang: minor code cleanups

Build Master (Inactive) added a comment - 12/Dec/11 8:02 PM

Integrated in lustre-master » i686,server,el6,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/llite/rw.c
libcfs/include/libcfs/linux/kp30.h
lustre/utils/gss/lgss_utils.c
lustre/fid/lproc_fid.c
lustre/tests/checkstat.c
lustre/liblustre/super.c
lustre/tests/truncate.c
lustre/utils/gss/lgss_keyring.c
lustre/llite/file.c
lustre/include/lustre_debug.h
lnet/utils/routerstat.c
libcfs/include/libcfs/posix/posix-wordsize.h

Build Master (Inactive) added a comment - 12/Dec/11 8:02 PM Integrated in lustre-master » i686,server,el6,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/llite/rw.c libcfs/include/libcfs/linux/kp30.h lustre/utils/gss/lgss_utils.c lustre/fid/lproc_fid.c lustre/tests/checkstat.c lustre/liblustre/super.c lustre/tests/truncate.c lustre/utils/gss/lgss_keyring.c lustre/llite/file.c lustre/include/lustre_debug.h lnet/utils/routerstat.c libcfs/include/libcfs/posix/posix-wordsize.h

Build Master (Inactive) added a comment - 12/Dec/11 7:56 PM

Integrated in lustre-master » i686,server,el5,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/utils/gss/lgss_keyring.c
lustre/liblustre/super.c
lustre/utils/gss/lgss_utils.c
lustre/llite/rw.c
lustre/tests/checkstat.c
lustre/llite/file.c
lnet/utils/routerstat.c
lustre/tests/truncate.c
lustre/fid/lproc_fid.c
lustre/include/lustre_debug.h
libcfs/include/libcfs/linux/kp30.h
libcfs/include/libcfs/posix/posix-wordsize.h

Build Master (Inactive) added a comment - 12/Dec/11 7:56 PM Integrated in lustre-master » i686,server,el5,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/utils/gss/lgss_keyring.c lustre/liblustre/super.c lustre/utils/gss/lgss_utils.c lustre/llite/rw.c lustre/tests/checkstat.c lustre/llite/file.c lnet/utils/routerstat.c lustre/tests/truncate.c lustre/fid/lproc_fid.c lustre/include/lustre_debug.h libcfs/include/libcfs/linux/kp30.h libcfs/include/libcfs/posix/posix-wordsize.h

Build Master (Inactive) added a comment - 12/Dec/11 7:46 PM

Integrated in lustre-master » x86_64,server,el5,ofa #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = FAILURE
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

libcfs/include/libcfs/linux/kp30.h
lustre/llite/file.c
lustre/utils/gss/lgss_utils.c
lustre/utils/gss/lgss_keyring.c
lustre/tests/truncate.c
libcfs/include/libcfs/posix/posix-wordsize.h
lustre/llite/rw.c
lnet/utils/routerstat.c
lustre/tests/checkstat.c
lustre/fid/lproc_fid.c
lustre/liblustre/super.c
lustre/include/lustre_debug.h

Build Master (Inactive) added a comment - 12/Dec/11 7:46 PM Integrated in lustre-master » x86_64,server,el5,ofa #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = FAILURE Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : libcfs/include/libcfs/linux/kp30.h lustre/llite/file.c lustre/utils/gss/lgss_utils.c lustre/utils/gss/lgss_keyring.c lustre/tests/truncate.c libcfs/include/libcfs/posix/posix-wordsize.h lustre/llite/rw.c lnet/utils/routerstat.c lustre/tests/checkstat.c lustre/fid/lproc_fid.c lustre/liblustre/super.c lustre/include/lustre_debug.h

Build Master (Inactive) added a comment - 12/Dec/11 7:41 PM

Integrated in lustre-master » i686,client,el5,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/tests/truncate.c
lustre/liblustre/super.c
libcfs/include/libcfs/posix/posix-wordsize.h
lustre/tests/checkstat.c
lnet/utils/routerstat.c
lustre/include/lustre_debug.h
lustre/utils/gss/lgss_utils.c
lustre/llite/file.c
lustre/utils/gss/lgss_keyring.c
libcfs/include/libcfs/linux/kp30.h
lustre/fid/lproc_fid.c
lustre/llite/rw.c

Build Master (Inactive) added a comment - 12/Dec/11 7:41 PM Integrated in lustre-master » i686,client,el5,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/tests/truncate.c lustre/liblustre/super.c libcfs/include/libcfs/posix/posix-wordsize.h lustre/tests/checkstat.c lnet/utils/routerstat.c lustre/include/lustre_debug.h lustre/utils/gss/lgss_utils.c lustre/llite/file.c lustre/utils/gss/lgss_keyring.c libcfs/include/libcfs/linux/kp30.h lustre/fid/lproc_fid.c lustre/llite/rw.c

Build Master (Inactive) added a comment - 12/Dec/11 7:25 PM

Integrated in lustre-master » i686,client,el5,ofa #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lnet/utils/routerstat.c
libcfs/include/libcfs/linux/kp30.h
libcfs/include/libcfs/posix/posix-wordsize.h
lustre/llite/file.c
lustre/llite/rw.c
lustre/liblustre/super.c
lustre/tests/checkstat.c
lustre/include/lustre_debug.h
lustre/utils/gss/lgss_utils.c
lustre/utils/gss/lgss_keyring.c
lustre/tests/truncate.c
lustre/fid/lproc_fid.c

Build Master (Inactive) added a comment - 12/Dec/11 7:25 PM Integrated in lustre-master » i686,client,el5,ofa #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lnet/utils/routerstat.c libcfs/include/libcfs/linux/kp30.h libcfs/include/libcfs/posix/posix-wordsize.h lustre/llite/file.c lustre/llite/rw.c lustre/liblustre/super.c lustre/tests/checkstat.c lustre/include/lustre_debug.h lustre/utils/gss/lgss_utils.c lustre/utils/gss/lgss_keyring.c lustre/tests/truncate.c lustre/fid/lproc_fid.c

Build Master (Inactive) added a comment - 12/Dec/11 6:55 PM

Integrated in lustre-master » x86_64,server,el5,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/tests/truncate.c
lustre/utils/gss/lgss_utils.c
lustre/llite/file.c
lustre/llite/rw.c
lustre/include/lustre_debug.h
lustre/fid/lproc_fid.c
lustre/utils/gss/lgss_keyring.c
libcfs/include/libcfs/posix/posix-wordsize.h
libcfs/include/libcfs/linux/kp30.h
lustre/tests/checkstat.c
lustre/liblustre/super.c
lnet/utils/routerstat.c

Build Master (Inactive) added a comment - 12/Dec/11 6:55 PM Integrated in lustre-master » x86_64,server,el5,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/tests/truncate.c lustre/utils/gss/lgss_utils.c lustre/llite/file.c lustre/llite/rw.c lustre/include/lustre_debug.h lustre/fid/lproc_fid.c lustre/utils/gss/lgss_keyring.c libcfs/include/libcfs/posix/posix-wordsize.h libcfs/include/libcfs/linux/kp30.h lustre/tests/checkstat.c lustre/liblustre/super.c lnet/utils/routerstat.c

Build Master (Inactive) added a comment - 12/Dec/11 6:50 PM

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/liblustre/super.c
lnet/utils/routerstat.c
lustre/utils/gss/lgss_utils.c
lustre/tests/checkstat.c
lustre/llite/rw.c
lustre/tests/truncate.c
libcfs/include/libcfs/linux/kp30.h
lustre/include/lustre_debug.h
lustre/llite/file.c
lustre/fid/lproc_fid.c
libcfs/include/libcfs/posix/posix-wordsize.h
lustre/utils/gss/lgss_keyring.c

Build Master (Inactive) added a comment - 12/Dec/11 6:50 PM Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/liblustre/super.c lnet/utils/routerstat.c lustre/utils/gss/lgss_utils.c lustre/tests/checkstat.c lustre/llite/rw.c lustre/tests/truncate.c libcfs/include/libcfs/linux/kp30.h lustre/include/lustre_debug.h lustre/llite/file.c lustre/fid/lproc_fid.c libcfs/include/libcfs/posix/posix-wordsize.h lustre/utils/gss/lgss_keyring.c

Build Master (Inactive) added a comment - 12/Dec/11 6:49 PM

Integrated in lustre-master » x86_64,client,el5,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lnet/utils/routerstat.c
lustre/tests/truncate.c
lustre/fid/lproc_fid.c
lustre/liblustre/super.c
libcfs/include/libcfs/linux/kp30.h
lustre/tests/checkstat.c
lustre/utils/gss/lgss_keyring.c
lustre/include/lustre_debug.h
lustre/llite/rw.c
lustre/utils/gss/lgss_utils.c
lustre/llite/file.c
libcfs/include/libcfs/posix/posix-wordsize.h

Build Master (Inactive) added a comment - 12/Dec/11 6:49 PM Integrated in lustre-master » x86_64,client,el5,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lnet/utils/routerstat.c lustre/tests/truncate.c lustre/fid/lproc_fid.c lustre/liblustre/super.c libcfs/include/libcfs/linux/kp30.h lustre/tests/checkstat.c lustre/utils/gss/lgss_keyring.c lustre/include/lustre_debug.h lustre/llite/rw.c lustre/utils/gss/lgss_utils.c lustre/llite/file.c libcfs/include/libcfs/posix/posix-wordsize.h

Build Master (Inactive) added a comment - 12/Dec/11 6:47 PM

Integrated in lustre-master » i686,client,el6,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/tests/checkstat.c
lustre/tests/truncate.c
libcfs/include/libcfs/linux/kp30.h
lustre/liblustre/super.c
libcfs/include/libcfs/posix/posix-wordsize.h
lustre/utils/gss/lgss_utils.c
lustre/fid/lproc_fid.c
lustre/llite/rw.c
lustre/llite/file.c
lustre/utils/gss/lgss_keyring.c
lustre/include/lustre_debug.h
lnet/utils/routerstat.c

Build Master (Inactive) added a comment - 12/Dec/11 6:47 PM Integrated in lustre-master » i686,client,el6,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/tests/checkstat.c lustre/tests/truncate.c libcfs/include/libcfs/linux/kp30.h lustre/liblustre/super.c libcfs/include/libcfs/posix/posix-wordsize.h lustre/utils/gss/lgss_utils.c lustre/fid/lproc_fid.c lustre/llite/rw.c lustre/llite/file.c lustre/utils/gss/lgss_keyring.c lustre/include/lustre_debug.h lnet/utils/routerstat.c

Build Master (Inactive) added a comment - 12/Dec/11 6:44 PM

Integrated in lustre-master » x86_64,client,el5,ofa #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/liblustre/super.c
lustre/tests/truncate.c
lustre/llite/rw.c
lustre/fid/lproc_fid.c
libcfs/include/libcfs/posix/posix-wordsize.h
libcfs/include/libcfs/linux/kp30.h
lustre/tests/checkstat.c
lnet/utils/routerstat.c
lustre/utils/gss/lgss_utils.c
lustre/utils/gss/lgss_keyring.c
lustre/llite/file.c
lustre/include/lustre_debug.h

Build Master (Inactive) added a comment - 12/Dec/11 6:44 PM Integrated in lustre-master » x86_64,client,el5,ofa #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/liblustre/super.c lustre/tests/truncate.c lustre/llite/rw.c lustre/fid/lproc_fid.c libcfs/include/libcfs/posix/posix-wordsize.h libcfs/include/libcfs/linux/kp30.h lustre/tests/checkstat.c lnet/utils/routerstat.c lustre/utils/gss/lgss_utils.c lustre/utils/gss/lgss_keyring.c lustre/llite/file.c lustre/include/lustre_debug.h

Build Master (Inactive) added a comment - 12/Dec/11 6:40 PM

Integrated in lustre-master » x86_64,server,el6,inkernel #378
~~LU-871~~ build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624)

Result = SUCCESS
Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624
Files :

lustre/utils/gss/lgss_utils.c
lustre/include/lustre_debug.h
lustre/liblustre/super.c
libcfs/include/libcfs/posix/posix-wordsize.h
lustre/fid/lproc_fid.c
lustre/utils/gss/lgss_keyring.c
lnet/utils/routerstat.c
lustre/tests/truncate.c
lustre/llite/file.c
libcfs/include/libcfs/linux/kp30.h
lustre/llite/rw.c
lustre/tests/checkstat.c

Build Master (Inactive) added a comment - 12/Dec/11 6:40 PM Integrated in lustre-master » x86_64,server,el6,inkernel #378 LU-871 build: change %L printk format to %ll (Revision 3684de257a7e8932936a27d0fdb3ecb39653e624) Result = SUCCESS Oleg Drokin : 3684de257a7e8932936a27d0fdb3ecb39653e624 Files : lustre/utils/gss/lgss_utils.c lustre/include/lustre_debug.h lustre/liblustre/super.c libcfs/include/libcfs/posix/posix-wordsize.h lustre/fid/lproc_fid.c lustre/utils/gss/lgss_keyring.c lnet/utils/routerstat.c lustre/tests/truncate.c lustre/llite/file.c libcfs/include/libcfs/linux/kp30.h lustre/llite/rw.c lustre/tests/checkstat.c

People

Assignee:: Andreas Dilger

Reporter:: Andreas Dilger

Votes:: 1 Vote for this issue

Watchers:: 5 Start watching this issue

Dates

Created:: 21/Nov/11 5:47 PM

Updated:: 05/Feb/13 5:41 PM

Resolved:: 05/Feb/13 5:41 PM