Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8774

copy_from_user() should not use MAX_STRING_SIZE

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.9.0
    • Lustre 2.9.0
    • None
    • 3
    • 9223372036854775807

    Description

      The following codes are incorrect:

      $ git grep "MAX_STRING_SIZE" | grep copy_from_user
lustre/ldlm/ldlm_resource.c:	if (copy_from_user(dummy, buffer, MAX_STRING_SIZE))
lustre/obdclass/lprocfs_status.c:	if (copy_from_user(dummy, buffer, MAX_STRING_SIZE))

      We should only copy enough bytes to cover count passed in.

      Attachments

        Activity

          [LU-8774] copy_from_user() should not use MAX_STRING_SIZE
          mdiep Minh Diep made changes -
          Link Original: This issue is related to LDEV-301 [ LDEV-301 ]
          mdiep Minh Diep made changes -
          Link New: This issue is related to LDEV-608 [ LDEV-608 ]
          pjones Peter Jones made changes -
          Link New: This issue is related to JFC-17 [ JFC-17 ]
          adilger Andreas Dilger made changes -
          Link New: This issue is related to LDEV-243 [ LDEV-243 ]
          adilger Andreas Dilger made changes -
          Link New: This issue is related to LDEV-301 [ LDEV-301 ]
          yujian Jian Yu made changes -
          Fix Version/s New: Lustre 2.9.0 [ 11891 ]
          Resolution New: Fixed [ 1 ]
          Status Original: Open [ 1 ] New: Resolved [ 5 ]
          pjones Peter Jones made changes -
          Link New: This issue is duplicated by SGI-237 [ SGI-237 ]
          yujian Jian Yu made changes -
          Assignee Original: WC Triage [ wc-triage ] New: Jian Yu [ yujian ]
          yujian Jian Yu created issue -

          People

            yujian Jian Yu
            yujian Jian Yu
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: