Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-8888

Remove unused clt_current_io from struct cl_thread_info

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • Lustre 2.10.0
    • None
    • None
    • 3
    • 9223372036854775807

    Description

      The pointer to the topmost ongoing IO in the thread is not used.

      Attachments

        Activity

          [LU-8888] Remove unused clt_current_io from struct cl_thread_info
          pjones Peter Jones made changes -
          Fix Version/s New: Lustre 2.10.0 [ 12204 ]
          Resolution New: Fixed [ 1 ]
          Status Original: In Progress [ 3 ] New: Resolved [ 5 ]
          pjones Peter Jones added a comment -

          Landed for 2.10

          pjones Peter Jones added a comment - Landed for 2.10
          gerrit Gerrit Updater added a comment -

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/24062/
          Subject: LU-8888 clio: remove unused members from struct cl_thread_info
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: ad8f66967d66238539700081d555ebc08e43cead

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/24062/ Subject: LU-8888 clio: remove unused members from struct cl_thread_info Project: fs/lustre-release Branch: master Current Patch Set: Commit: ad8f66967d66238539700081d555ebc08e43cead
          dmiter Dmitry Eremin (Inactive) made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          dmiter Dmitry Eremin (Inactive) added a comment -

          Thanks John, I updated the patch.

          dmiter Dmitry Eremin (Inactive) added a comment - Thanks John, I updated the patch.
          jhammond John Hammond added a comment -

          There are several unused fields in struct cl_thread_info:

          t:lustre-release# grep cl_thread_info DeclUse-2.8.60-24-g075f98e/Unused
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_descr
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_fn_index
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_io
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_list
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_next_index
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_pvec
Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_queue
          jhammond John Hammond added a comment - There are several unused fields in struct cl_thread_info : t:lustre-release# grep cl_thread_info DeclUse-2.8.60-24-g075f98e/Unused Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_descr Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_fn_index Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_io Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_list Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_next_index Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_pvec Field /root/lustre-release/lustre/obdclass/cl_internal.h:55:8:cl_thread_info:clt_queue
          gerrit Gerrit Updater added a comment -

          Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/24062
          Subject: LU-8888 clio: remove clt_current_io from struct cl_thread_info
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: ca8bf62e89f2ead8163c35728d7e12101944003d

          gerrit Gerrit Updater added a comment - Dmitry Eremin (dmitry.eremin@intel.com) uploaded a new patch: http://review.whamcloud.com/24062 Subject: LU-8888 clio: remove clt_current_io from struct cl_thread_info Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: ca8bf62e89f2ead8163c35728d7e12101944003d
          dmiter Dmitry Eremin (Inactive) created issue -

          People

            dmiter Dmitry Eremin (Inactive)
            dmiter Dmitry Eremin (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: