Uploaded image for project: 'Lustre'
  1. Lustre
  2. LU-9753

OFD destroy non-orphan OST-object because of overflow

Details

    • 3
    • 9223372036854775807

    Description

      In ofd_create_hdl(), the logic will compare the OST stroed LAST_ID with the MDT given one: if the difference exceeds some threshold, then it will trust the OST LAST_ID directly and reset the MDT side value with the OST one. Otherwise, the orphan OST-objects will be destroyed.

      Unfortunately, both the OST stored LAST_ID and MDT given one are 64 bits, but the @diff variable is only 32 bits, and if the OST side value is too larger than the MDT side, then the @diff will overflow. That will misguide the OST to destroy useful OST-objects by wrong.

      Attachments

        Activity

          [LU-9753] OFD destroy non-orphan OST-object because of overflow

          John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/28230/
          Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow
          Project: fs/lustre-release
          Branch: b2_10
          Current Patch Set:
          Commit: 9903e1efd9bb1ddf0d74513c5036169d4a651bfe

          gerrit Gerrit Updater added a comment - John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/28230/ Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow Project: fs/lustre-release Branch: b2_10 Current Patch Set: Commit: 9903e1efd9bb1ddf0d74513c5036169d4a651bfe

          Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/28230
          Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow
          Project: fs/lustre-release
          Branch: b2_10
          Current Patch Set: 1
          Commit: bc01869cf4a41c85aa6b171a54a3fb197bd2ae6f

          gerrit Gerrit Updater added a comment - Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/28230 Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow Project: fs/lustre-release Branch: b2_10 Current Patch Set: 1 Commit: bc01869cf4a41c85aa6b171a54a3fb197bd2ae6f

          Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/27975/
          Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow
          Project: fs/lustre-release
          Branch: master
          Current Patch Set:
          Commit: 03bbd4c27471751ada57282fad15e074ae01e9d7

          gerrit Gerrit Updater added a comment - Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/27975/ Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow Project: fs/lustre-release Branch: master Current Patch Set: Commit: 03bbd4c27471751ada57282fad15e074ae01e9d7

          Fan Yong (fan.yong@intel.com) uploaded a new patch: https://review.whamcloud.com/27975
          Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow
          Project: fs/lustre-release
          Branch: master
          Current Patch Set: 1
          Commit: 7e7406048e602d7d1145ed7a77e6a92475322811

          gerrit Gerrit Updater added a comment - Fan Yong (fan.yong@intel.com) uploaded a new patch: https://review.whamcloud.com/27975 Subject: LU-9753 ofd: 64-bits diff variable to avoid overflow Project: fs/lustre-release Branch: master Current Patch Set: 1 Commit: 7e7406048e602d7d1145ed7a77e6a92475322811

          People

            yong.fan nasf (Inactive)
            yong.fan nasf (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: