[LU-1016] RPM build proceeds after failure Created: 20/Jan/12  Updated: 21/Nov/12  Resolved: 16/Apr/12

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.2.0
Fix Version/s: Lustre 2.3.0

Type: Improvement Priority: Major
Reporter: Bruce Korb (Inactive) Assignee: WC Triage
Resolution: Fixed Votes: 0
Labels: None
Environment:

build

Severity: 3
Rank (Obsolete): 4649

 Description   

Makefile scriptlets run with "set -e" set. This causes the shell to exit
if any commands exit with a non-zero exit code. This technique is DEFEATED
if part of the shell script runs in a subshell. If using a subshell is
necessary, then the scriptlet needs to test exit code. However, the code
at issue here does not need a subshell. autoMakefile.am.toplevel needs
two fixes:

1. when testing BUILD_SERVER and BUILD_TESTS, when not defined, the default
should be to not insert the extra buildrpm options.

if [[ -n "$(BUILD_TESTS)" -a "$(BUILD_TESTS)" = false ]]; then \
RPMARGS="$$RPMARGS --define \"build_lustre_tests 0\""; \
fi; \

the build is constrained to GNU Make on a Linux platform wherein
this "[[" form of "test" is legal.

2. when building in subdirectories, there is no need for a subshell:
rpms:
for subdir in $(RPM_SUBDIRS) ; do \
echo "Making rpms in $$subdir"; \
cd $$subdir ; \
$(MAKE) $(AM_MAKEFLAGS) $@ ; \
cd - ; \
echo "Finished rpms in $$subdir"; \
done; \
$(MAKE) $(AM_MAKEFLAGS) rpms-realq

srpm:
for subdir in $(RPM_SUBDIRS) ; do \
echo "Making srpm in $$subdir"; \
cd $$subdir ; \
$(MAKE) $(AM_MAKEFLAGS) $@ ; \
cd - ; \
echo "Finished srpms in $$subdir"; \
done; \
$(MAKE) $(AM_MAKEFLAGS) srpm-real

 Comments   
Comment by Bruce Korb (Inactive) [ 25/Jan/12 ]

Review: http://review.whamcloud.com/2012

Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,client,sles11,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,server,el5,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,server,el5,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,client,el5,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,client,el5,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,server,el5,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,client,el5,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,client,el5,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,server,el6,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,server,el6,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,server,el5,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,client,el6,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,server,el6,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,client,el6,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,client,el6,ofa #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » x86_64,server,el6,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 09/Apr/12 ]

Integrated in lustre-master » i686,client,el6,inkernel #480
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Peter Jones [ 16/Apr/12 ]

Landed for 2.3

Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,client,el5,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,client,el6,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,server,el5,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,server,el6,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » i686,client,el5,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,server,el5,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Build Master (Inactive) [ 02/May/12 ]

Integrated in lustre-dev » x86_64,client,el6,inkernel #340
LU-1016 build: no sub-builds in sub-shells (Revision cbc38177886815a41ca81b7f83e7f9ed578b604e)

Result = SUCCESS
Oleg Drokin : cbc38177886815a41ca81b7f83e7f9ed578b604e
Files :

  • build/autoMakefile.am.toplevel
Comment by Nathan Rutman [ 21/Nov/12 ]

Xyratex-bug-id: MRP-361

Generated at Sat Feb 10 01:12:41 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.