[LU-10220] Incorrect record length allocated in mdd_changelog_data_store_by_fid() Created: 09/Nov/17  Updated: 06/Dec/17  Resolved: 01/Dec/17

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: Lustre 2.10.1
Fix Version/s: Lustre 2.11.0, Lustre 2.10.2

Type: Bug Priority: Major
Reporter: Sebastien Buisson (Inactive) Assignee: Sebastien Buisson (Inactive)
Resolution: Fixed Votes: 0
Labels: changelogs, patch

Issue Links:
Related
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In mdd_changelog_data_store_by_fid(), the record length calculated to allocate mti_big_buf is not correct, because it forgets to take the header size of struct llog_changelog_rec into account.

I guess it never generated memory corruptions before, because the buffer size allocated in a previous call to mdd_declare_changelog_store() was covering the need.
But now that LU-9727 adds more information in changelog records, I am able to provoke memory corruptions.

I will submit a patch to fix this problem.

Sebastien.



 Comments   
Comment by Gerrit Updater [ 09/Nov/17 ]

Sebastien Buisson (sbuisson@ddn.com) uploaded a new patch: https://review.whamcloud.com/30014
Subject: LU-10220 mdd: fix buf alloc in mdd_changelog_data_store_by_fid
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 03640971633629d221a35b7fd2c1e8a49a7bca4a

Comment by Gerrit Updater [ 01/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30014/
Subject: LU-10220 mdd: fix buf alloc in mdd_changelog_data_store_by_fid
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f173f93032c62bd1f95330f331d3d93ce5a31598

Comment by Peter Jones [ 01/Dec/17 ]

Landed for 2.11

Comment by Gerrit Updater [ 04/Dec/17 ]

Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/30356
Subject: LU-10220 mdd: fix buf alloc in mdd_changelog_data_store_by_fid
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 7cee8538282b193b70137f4a38aa643d58194d64

Comment by Gerrit Updater [ 06/Dec/17 ]

John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/30356/
Subject: LU-10220 mdd: fix buf alloc in mdd_changelog_data_store_by_fid
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 5ecf0ab240334b48378a1dd7e8dea068f4ef31ab

Generated at Sat Feb 10 02:33:07 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.