[LU-10257] vvp_lock, lov_page, and lovsub_{lock,page} are (more or less) unused Created: 17/Nov/17 Updated: 04/Feb/20 Resolved: 03/May/18 |
|
| Status: | Closed |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||||||||||||||||||
| Severity: | 3 | ||||||||||||||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||||||||||||||
| Description |
|
struct vvp_lock, lovsub_lock and lovsub_page can be removed. Nothing happens if these layers are omitted from the corresponding cl_lock or cl_page object. If lps_index is moved to cl_page (which makes some sense based on how it's used) then lov_page can be similarly removed. Removing struct lov_page and lovsub_page reduces the size of a cl_page object from 448 to 344 bytes on x86_64 and puts us in shouting distance from using slab-256 for cl_pages. |
| Comments |
| Comment by Gerrit Updater [ 17/Nov/17 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/30161 |
| Comment by James A Simmons [ 17/Nov/17 ] |
|
Thank you for the cleanup. I had a discussion with Oleg some time ago about cleaning up CLIO since several parts of the API duplicates what the linux kernel already does. This is a good step in that direction. |
| Comment by Andreas Dilger [ 18/Nov/17 ] |
|
Jinshan, I recall at one time that this was needed for FLR client write redundancy? If not, then I'm happy to remove it, but it would be sad to take it out and then just add it back when FLR will use it. |
| Comment by Jinshan Xiong (Inactive) [ 18/Nov/17 ] |
|
Andreas, yes you remember it right. lov_page is still needed by FLR. |
| Comment by Gerrit Updater [ 21/Nov/17 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/30192 |
| Comment by Gerrit Updater [ 17/Dec/17 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30192/ |
| Comment by Joseph Gmitter (Inactive) [ 28/Mar/18 ] |
|
Do we still need any part of the original patch at https://review.whamcloud.com/30161 or can we resolve this as fixed for 2.11.0? |