[LU-10269] Fixes for selective trybits Created: 23/Nov/17  Updated: 02/Aug/18  Resolved: 04/Jan/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0

Type: Bug Priority: Major
Reporter: Mikhail Pershin Assignee: Mikhail Pershin
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Related
is related to LU-11199 mdsrate open() performance degradation Resolved
is related to LU-10948 client cache open lock after N opens Open
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

While checking the waiting queue for inodebits lock it is needed to take into account also try_bits of new lock and locks in that queue.

Another topic to solve in this ticket is the correct using of try_bits from callers and avoiding useless or trouble making cases with extra inodebits.



 Comments   
Comment by Gerrit Updater [ 24/Nov/17 ]

Mike Pershin (mike.pershin@intel.com) uploaded a new patch: https://review.whamcloud.com/30246
Subject: LU-10269 ldlm: fix the issues introduced by try bits
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 12e263639a91458e52db5759fbf80bfc97dd15ac

Comment by Gerrit Updater [ 02/Dec/17 ]

Mike Pershin (mike.pershin@intel.com) uploaded a new patch: https://review.whamcloud.com/30343
Subject: LU-10269 ldlm: allow trybits in waiting queue
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d37cd567182a9302ecb81e2e58b92e6d1ea8e615

Comment by Gerrit Updater [ 17/Dec/17 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30246/
Subject: LU-10269 ldlm: fix the issues introduced by try bits
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4f50273a3ed89bc00d5f36fc2606cc40680f450f

Comment by Oleg Drokin [ 04/Jan/18 ]

I think another desired thing would be to more selectively drop bits from trylocks.

For example if we see a granted lock that blocks us, OR a waiting lock that blocks up based on non-optional bits, reducing our bits (or bits of that waiting lock) is pointless - because we know we would conflict no matter what.

Comment by Gerrit Updater [ 04/Jan/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30343/
Subject: LU-10269 ldlm: allow trybits in waiting queue
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 916bfe080520bdfb9a8d4e35ce7095c5b632f4eb

Comment by Peter Jones [ 04/Jan/18 ]

Landed for 2.11

Generated at Sat Feb 10 02:33:33 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.