[#LU-1031] Add grouplock support to multiop

[LU-1031] Add grouplock support to multiop Created: 25/Jan/12 Updated: 05/Aug/20 Resolved: 06/Aug/12
Status:	Resolved
Project:	Lustre
Component/s:	None
Affects Version/s:	None
Fix Version/s:	Lustre 2.3.0

Type:

Improvement

Priority:

Minor

Reporter:

CEA

Assignee:

Andreas Dilger

Resolution:

Fixed

Votes:

Labels:

None

Issue Links:

Related
is related to	~~LU-787~~	ftruncate blocks when done holding a ...	Resolved

Rank (Obsolete):

4590

Description

Multiop command does not support grouplock
We propose to add it so we can add grouplock tests n sanity.sh

Comments

Comment by Andreas Dilger [ 25/Jan/12 ]

I was thinking it might be Better to add an lfs command to do grouplock on a file, so that it can be used by migrate scripts as well. Mulitop is not installed by default, so it is unsuitable for use by user scripts.

The grouplock should be held until the lfs command exits, which would ensure that it cannot be leaked if the user process is killed.

What do you think?

Comment by jacques-charles lafoucriere [ 25/Jan/12 ]

multiop is much more useful for sanity test than lfs. So in any case it will be good to have the grouplock support in it.
An issue with lfs implementation is that it is incompatible with the "grouplock unlock at close" behaviour.
This automatic "grouplock unlock" is nice when a process holding the grouplock crashes because we have no way to recover the lock if it is not memorised somewhere by the process. The only way today to free this lock is to reboot the node.

Comment by jacques-charles lafoucriere [ 05/Feb/12 ]

patch for multiop + new sanity test (simple grouplock test)

http://review.whamcloud.com/2098

Comment by jacques-charles lafoucriere [ 29/Mar/12 ]

After landing of ~~LU-787~~ I have updated the patch to change only sanity.sh to:

add a basic test for grouplock for single node test
replace use of hardcoded multiop by a $MULTIOP

Comment by jacques-charles lafoucriere [ 31/Mar/12 ]

I have updated the patch with same modification in other tests (sanityn, ...)

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » x86_64,client,el6,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/sanity-quota.sh
lustre/tests/sanity-gss.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/sanityn.sh
lustre/tests/sanity.sh
lustre/tests/replay-single.sh
lustre/tests/test-framework.sh
lustre/tests/recovery-small.sh

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » i686,client,el6,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/sanity-quota.sh
lustre/tests/recovery-small.sh
lustre/tests/sanity-gss.sh
lustre/tests/sanity.sh
lustre/tests/sanityn.sh
lustre/tests/test-framework.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/replay-single.sh

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » x86_64,client,el5,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/recovery-small.sh
lustre/tests/sanity-quota.sh
lustre/tests/sanity-gss.sh
lustre/tests/replay-single.sh
lustre/tests/test-framework.sh
lustre/tests/sanityn.sh
lustre/tests/sanity.sh
lustre/tests/runmultiop_bg_pause

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » i686,server,el5,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/replay-single.sh
lustre/tests/sanity-quota.sh
lustre/tests/recovery-small.sh
lustre/tests/sanityn.sh
lustre/tests/test-framework.sh
lustre/tests/sanity-gss.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/sanity.sh

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » x86_64,server,el6,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/test-framework.sh
lustre/tests/recovery-small.sh
lustre/tests/sanityn.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/sanity-quota.sh
lustre/tests/sanity-gss.sh
lustre/tests/sanity.sh
lustre/tests/replay-single.sh

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » i686,server,el6,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/replay-single.sh
lustre/tests/recovery-small.sh
lustre/tests/sanity.sh
lustre/tests/sanityn.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/sanity-quota.sh
lustre/tests/sanity-gss.sh
lustre/tests/test-framework.sh

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » x86_64,server,el5,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/sanity-gss.sh
lustre/tests/recovery-small.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/replay-single.sh
lustre/tests/test-framework.sh
lustre/tests/sanityn.sh
lustre/tests/sanity.sh
lustre/tests/sanity-quota.sh

Comment by Build Master (Inactive) [ 31/Mar/12 ]

Integrated in lustre-reviews » i686,client,el5,inkernel #4610
~~LU-1031~~: add grouplock test to sanity.sh (Revision 84917e27aa59abadffc654cac7b952f63b265689)

Result = SUCCESS
jcl : 84917e27aa59abadffc654cac7b952f63b265689
Files :

lustre/tests/sanity.sh
lustre/tests/test-framework.sh
lustre/tests/runmultiop_bg_pause
lustre/tests/sanityn.sh
lustre/tests/recovery-small.sh
lustre/tests/sanity-quota.sh
lustre/tests/replay-single.sh
lustre/tests/sanity-gss.sh