[LU-10467] use standard linux wait_event macros

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.14.0
• Type: Improvement
• Priority: Major
• Reporter: James A Simmons
• Assignee: James A Simmons
• Resolution: Fixed

Description

Simplify l_wait_info() using the linux wait_event infrastructure.

Improvements are:

   - new wait_event_idle* macros are now in include/linux/wait.h which

     Ack from peterz.

   - all waits are now TASK_IDLE or TASK_INTERRUPTIBLE and so don't

     affect the load average.  There is no need to choose whether load

     is appropriate or not in each case.

   - all l_wait_event() users are handled so l_wait_event() is

     removed.  The one case I had left out before uses

     wait_event_idle_exclusive() with and option of using

     wait_event_idle_exclusive_lifo() is that ever gets approved.

Issue Links

• is related to: LU-6431 do not call blocking ops when !TASK_R...
• is related to: LU-4423 Tracking of patches from upstream ker...
• is related to: LU-10824 ll_umount being improper use of cache...
• is related to: LU-1882 conf-sanity test_45: umount2: Device ...
• is related to: LU-8841 Replace l_wait_info calls that use ze...
• is related to: LU-12362 kernel warning 'do not call blocking ...
• is related to: LU-12436 Memory allocation failure error dropped
• is related to: LU-12511 Prepare lustre for adoption into the ...

Comments

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/34956
Subject: LU-10467 ptlrpc: discard SVC_SIGNAL and related functions
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 18b7ad2f0010b5f249a4092d489485903afc3cd1

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/34956/
Subject: LU-10467 ptlrpc: discard SVC_SIGNAL and related functions
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 02aa25019db411ef6a3e8ea39900db5737672e87

[Peter Jones]

Landed for 2.13

[James A Simmons]

Actually there is a bunch more. Was waiting for the wait_var_event() patch from LU-11089 to land.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35967/
Subject: LU-10467 llite: fix indentation
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aaa3156f88547586e9d928ecc00001be102cb5b3

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36102
Subject: LU-10467 obdclass: convert waiting in cl_sync_io_wait().
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 38641f74b91f8643a2b95d12d5804eb864c25cfe

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35963/
Subject: LU-10467 fid: style cleanups in seq_client_alloc_meta()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7404a3e355eeed661c6ee669c05d9e6a24ed592f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35970/
Subject: LU-10467 lustre: use TABs for indents in a few places.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c71c6d786cbee5341e37b1eec13e9f06e49ca37a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35976/
Subject: LU-10467 ptlrpc: fix indents in ptlrpc_recover_import()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d87a34a11ddca0659ce2a1fc3d0dbfab9a7d4625

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35962/
Subject: LU-10467 lustre: add wait_event macros suitable for upstream
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f6df31a163806c38c734add346ed7cbfe427cce4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35969/
Subject: LU-10467 target: remove lwi arg from target_bulk_io
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 67dd631e6075b37eac0472d7b83a1a55f2be915f

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36343
Subject: LU-10467 lov: use wait_event() in lov_subobject_kill()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: f2bfbf73223af727a9bbf01fa8abf3b9958681ad

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/36345
Subject: LU-10467 llite: use wait_event in cl_object_put_last()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 95ed019543321645cac68a01bbd74af603effefa

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35966/
Subject: LU-10467 lustre: don't use l_wait_event() for simple sleep.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 077b35568be57f02c389b31553e17d5247d76897

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35968/
Subject: LU-10467 lustre: don't use l_wait_event() for poll loops.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d0ca764a1a9116238f64f4f6e1ded116d5d28ed0

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35971/
Subject: LU-10467 lustre: use wait_event_idle() where appropriate.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fa9c4d0fee01d30d538a819f370f281431a43f68

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35974/
Subject: LU-10467 llite: style fixes prior to code change.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 45514f5d42024510734a92de2746e2f6a336cff8

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35978/
Subject: LU-10467 ptlrpc: fix style issues in import.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b3ab87f5daa54fd8c4e2053587dc14b47d003420

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35983/
Subject: LU-10467 ldlm: fix style issues in ldlm_flock_completion_ast
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b89de85ef4dbd047e626986d977f105d8ba26f7c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35989/
Subject: LU-10467 ldlm: convert l_wait_event in __ldlm_namespace_free
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6a576848dfed0090602da6975dcbfa0a87adc3be

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36343/
Subject: LU-10467 lov: use wait_event() in lov_subobject_kill()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c0894d1d326701620c0b5538155053e7d93e719d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36345/
Subject: LU-10467 llite: use wait_event in cl_object_put_last()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f963f19c94b547a3ae11a0caf249c53b4426456c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35977/
Subject: LU-10467 lustre: use wait_event_idle_timeout() as appropriate.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a7ff5d050ee7db0e80baac5fb3848ffcfa04dea6

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35987/
Subject: LU-10467 ptlrpc: convert waiting in sptlrpc_req_refresh_ctx()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c1fad6a9a583b395c23ea1a102f1b67c50640f6f

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35988/
Subject: LU-10467 osp: use wait_event_idle_timeout()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 216e1efa8f12e113dbbb8f0ae2b00efe58cccac4

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35981/
Subject: LU-10467 ptlrpc: refactor waiting in ptlrpc_set_wait()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 609246d13db6de87d1cf32b34607346ff56dd30d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/36102/
Subject: LU-10467 obdclass: convert waiting in cl_sync_io_wait().
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: d6ce546eb7e250237141d3a11380f9d5389c50eb

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35973/
Subject: LU-10467 lustre: convert most users of LWI_TIMEOUT_INTERVAL()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5e30a2c06176f50f5e17aba68fdae7e38d922d33

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35980/
Subject: LU-10467 lustre: convert users of back_to_sleep()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: ca6c35cab141597809c6f3a58102fac8ac86104a

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35982/
Subject: LU-10467 ptlrpc: convert waiters on set->set_waitq
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4e5855ae4dea7954ce1891cd23abce033fe23f03

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35984/
Subject: LU-10467 ldlm: convert waiting in ldlm_flock_completion_ast()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f10a447fb4ca44d396f7f17bdceedfbd03ab2581

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35985/
Subject: LU-10467 ldlm: convert waiting in ldlm_completion_ast()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 366959b8cba5b022b4c1ea9aaba47ac14d4fff7e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35986/
Subject: LU-10467 ptlrpc: convert use of l_wait_event_exclusive_head()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: fb291dbf72ecd32847f1499776a441126f28e9bf

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37488
Subject: LU-10467 mdc: change ssleep to msleep_interruptible
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ed3e547e98ee6e64fabf3dbabcb51b04618828b4

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37609
Subject: LU-10467 ldlm: use wait_event_idle() instead of l_wait_event
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: ec5ea2af5bfb940a8ba99633ecd826d2d074c395

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37610
Subject: LU-10467 lfsck: use wait_event_idle()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 646c4bb32ba8904dd0dea5aadcaadae4550dca44

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35975/
Subject: LU-10467 lustre: use l_wait_event_abortable where appropriate.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 79d51f6c1d9f04aac3e7cbbedadf43a72520d424

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/35979/
Subject: LU-10467 ptlrpc: convert final users of LWI_TIMEOUT_INTERVAL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c30da8bfa199205194eefca2c5d2e6843a29a34b

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37696
Subject: LU-10467 ptlrpc: convert waiting in ptlrpc_hr_main()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 6c29c646724eb104ac05ecef0776f0fa13849d16

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37488/
Subject: LU-10467 mdc: change ssleep to msleep_interruptible
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 23cdbb827eee6ee298ed2462dccd3abcf1589f37

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37609/
Subject: LU-10467 ldlm: use wait_event_idle() instead of l_wait_event
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8284e02eb1631321c07767ed2d1db627592f0b4c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37610/
Subject: LU-10467 lfsck: use wait_event_idle()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 99d501a0cbd0195d3235dbb91b95952bad938cfa

[James A Simmons]

Down to two patches - 

https://review.whamcloud.com/#/c/37696/

https://review.whamcloud.com/#/c/37473/

Plus we will need one cleanup patch.

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/37729
Subject: LU-10467 libcfs: remove l_wait_event() and related macros.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 017a47e4eaf756ec54a431ee17aadf37cdc7b888

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37696/
Subject: LU-10467 ptlrpc: convert waiting in ptlrpc_hr_main()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 5891fbfad266623631e89d9f349722343592220d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/37729/
Subject: LU-10467 libcfs: remove l_wait_event() and related macros.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 39287411e32aeeed342c7da8417975e97310cd4a

[James A Simmons]

This work is now complete!!!!

[Peter Jones]

Amazing! Congrats

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38403
Subject: LU-10467 llite: clean up pcc_layout_wait()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 24412377207fa449847bf193707fc74c2de9e42c

[Gerrit Updater]

Neil Brown ([e-mail]) uploaded a new patch: https://review.whamcloud.com/38405
Subject: LU-10467 ptlrpc: change LONG_UNLINK to PTLRPC_LONG_REQ_UNLINK
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 397675ad40fbfdea1dbd7e4667e38b3358501a24

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38403/
Subject: LU-10467 llite: clean up pcc_layout_wait()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: c5a311781fc60c9a91483b737d3f59096949439e

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/38405/
Subject: LU-10467 ptlrpc: change LONG_UNLINK to PTLRPC_REQ_LONG_UNLINK
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 7c549da4014a7c7f7f662876115db16f4b05d74c