[LU-10515] lustre_rsync should not call register_ioc_dev() Created: 15/Jan/18 Updated: 25/Jan/18 Resolved: 25/Jan/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | John Hammond | Assignee: | John Hammond |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
lustre_rsync does not use /dev/obd and therefore does not need to call register_ioc_dev(). |
| Comments |
| Comment by Gerrit Updater [ 15/Jan/18 ] |
|
John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/30870 |
| Comment by John Hammond [ 15/Jan/18 ] |
|
It should also not depend on libcfs/util/parser.h or linux/lnet/libcfs_debug.h. In fact it's mixing use of locally defined DTRACE with D_TRACE from libcfs_debug.h which is a bug. |
| Comment by James A Simmons [ 15/Jan/18 ] |
|
The libcfs_debug.h is the UAPI header not the core header. See lustre-2.10.56/lnet/include/uapi/linux/lnet/libcfs_debug.h. It contains the defines for lctl set_param debug to work. As for parser.h that is for libreadline support. That is most likely safe to remove. |
| Comment by John Hammond [ 15/Jan/18 ] |
|
> The libcfs_debug.h is the UAPI header not the core header. See lustre-2.10.56/lnet/include/uapi/linux/lnet/libcfs_debug.h. It contains the defines for lctl set_param debug to work lustre_rsync does not depend on any of this functionality and therefore should not be including libcfs_debug.h. |
| Comment by Gerrit Updater [ 25/Jan/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/30870/ |
| Comment by Peter Jones [ 25/Jan/18 ] |
|
Landed for 2.11 |