[LU-10560] Fixes for 4.14 kernel

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.12.0
• Type: Bug
• Priority: Minor
• Reporter: Amir Shehata (Inactive)
• Assignee: James A Simmons
• Resolution: Fixed
• Labels: llnl
• Severity: 3

Description

While Mike Marciniszyn was testing the TID-RDMA he tried to build Lustre against upstream. And ran into this build error:

make[3]: Entering directory `/nfs/sc/disks/fabric_work/mmarciniszyn/repos/wfr/wf                                                                                                                                                             r-linux-devel'
  CC [M]  /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-tracefile.o
  CC [M]  /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-debug.o
In file included from /nfs/sc/disks/fabric_work/mmarciniszyn/repos/lustre-release/libcfs/libcfs/linux/linux-debug.c:50:0:
./arch/x86/include/asm/uaccess.h: In function ‘set_fs’:
./arch/x86/include/asm/uaccess.h:31:9: error: dereferencing pointer to incomplete type
  current->thread.addr_limit = fs; 

Issue Links

• is related to: LU-10805 fixes for 4.15 kernel
• is related to: LU-10997 Ubuntu 18 support
• is related to: LU-10934 integrate statx() API with Lustre
• is related to: LU-11132 LC_BI_BDEV: configuration problem for...
• is related to: LU-9558 Support linux kernel version 4.12
• is related to: LU-11310 support for SLES 15

Comments

[Gerrit Updater]

Andreas Dilger ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31007
Subject: LU-10560 libcfs: remove extra headers from linux-debug.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: a8aeb8cfb5e074530e044a1315de1e151061fa0e

[Amir Shehata (Inactive)]

Some more identified issue with Lustre compile against upstream kernel:

Some additional portability issues:

• GFP_TEMPORARY went away
• wait_queue_t changes to wait_queue_entry_t
• gss underpinnings changes (disabled gss)
• asm/uaccess deleted (as with abvoe patch)
  o lustre/llite/llite_mmap.c
  o lustre/llite/rw26.c

[James A Simmons]

I have a patch for the wait_queue_t changes. Just haven't pushed them yet. How new of a kernel do you need?

[Mike Marciniszyn (Inactive)]

I have patches for all the above issues as well.

An additional issue is with libcfs. vfs_write() is not exported in some cases.

I have a patch for that probes for kernel_write()

[Gerrit Updater]

Mike Marciniszyn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31153
Subject: LU-10560 lustre_compat: handle rename to wait_queue_entry_t
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c947398bd9bdc0dc676ac6296f02545379050cc5

[Gerrit Updater]

Mike Marciniszyn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31154
Subject: LU-10560 lustre_compat: Use kernel_write when no vfs_write
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 258b5a7e3b55eafac66d94d11aed97aba59d5807

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31007/
Subject: LU-10560 libcfs: remove extra headers from linux-debug.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a4ac52a7d08540802f899b115c74f7b9cdd0c5d7

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31150/
Subject: LU-10560 llite: remove extra headers from llite_mmap.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: aae9a90ce7c967c208c482e0ef500c5115017388

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31151/
Subject: LU-10560 llite: remove extra headers from rw26.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b8e87b5a1c17048a760ce9809fde904ca6dc449d

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31152/
Subject: LU-10560 lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f01bed03905d424fab81bee84a7b622f141e4f79

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31153/
Subject: LU-10560 libcfs: handle rename to wait_queue_entry_t
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9b7ca14430edf84f8c031b1489b3c0d2fb617535

[Olaf Faaland]

I see the LTS label.  Will this ticket also be used to track the backports?

I added the llnl label because we have an aarch64 cluster for testing and are attempting to build and use the Lustre 2.10 client there.  Some weeks ago RHEL for arm used a 4.11-based kernel, and Lustre 2.10 client built with minor adjustments.   Since then, RHEL moved to a 4.14-based kernel and much more change is required.

[James A Simmons]

Seriously. I will be seeing this update soon. I guess I need to resolve the last patch.

[James A Simmons]

Any chance to land the last patch to make this work complete?

 

[Gerrit Updater]

Li Dongyang ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31746
Subject: LU-10560 mdt: remove extra headers from mdt_identity.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: c129c4882f210050db8e9a57fbb96c9a917fb8d7

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31154/
Subject: LU-10560 libcfs: Use kernel_write when appropriate
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: b9a32054600a8d63948cced361191aa6ae7ea8f2

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31746/
Subject: LU-10560 mdt: remove extra headers from mdt_identity.c
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 9ade609b73d9b8ac750dec874a7209b07bcb86cb

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31923
Subject: LU-10560 libcfs: remove extra headers from linux-debug.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 19158ff6d97668830353388b334eb23da986f8fb

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31924
Subject: LU-10560 llite: remove extra headers from llite_mmap.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 480ba0e10974d1e6a6037c67069fe8f528598b1b

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31925
Subject: LU-10560 llite: remove extra headers from rw26.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: ff9ab6a368ce3bf2187b047051b7eefc7a997ae0

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31926
Subject: LU-10560 lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: e22e1cd2631e3c4a85577d001d5b0571fe8f77eb

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31927
Subject: LU-10560 libcfs: handle rename to wait_queue_entry_t
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 13e2315bf370f67845770a34c658a83ab26a9720

[Gerrit Updater]

Minh Diep ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31928
Subject: LU-10560 libcfs: Use kernel_write when appropriate
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 94d96caa0986d6ff539d75496f3443f159f32313

[Gerrit Updater]

Mike Marciniszyn ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31948
Subject: LU-10560 libcfs: Fix inconsistent const for cfg_kernel_write()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 874d454c7aeafb849862778dc6f163cc9c1938d7

[Peter Jones]

mmarcini is this now the last patch or are there still more to come?

[Mike Marciniszyn (Inactive)]

I noted that that the error in the backport in https://review.whamcloud.com/#/c/31928 and that is probably due to the const discrepancy.

This is the only issue I have with 4.14.x kernel and it as it is working fine for our testing.

There are issues with 4.15.x, but i haven't gotten to those yet.   Some notables:

• timer API changes
• const nits

My objective here is to do some Lustre testing with our upstream work for OPA (lnet_selftest, lnet_ping)

[Peter Jones]

Ok. 4.15 work is happening under LU-10805 but it sounds like this last change should be enough to support 4.14 - thanks!

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31948/
Subject: LU-10560 libcfs: Fix inconsistent declaration for cfs_kernel_write()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f19699186d29ba8561d67b4457e98c018ea26317

[James A Simmons]

We have a patch for ldiskfs under this ticket so don't close.

[Gerrit Updater]

Yang Sheng ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32268
Subject: LU-10560 llite: remove assigning f_version in ll_readir.
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 1de9c46e2dbb64cf788f40e52bf829b334b9da0c

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/31923/
Subject: LU-10560 libcfs: remove extra headers from linux-debug.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 9892581f02a9602edf345edb12370d92207ffc87

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/31924/
Subject: LU-10560 llite: remove extra headers from llite_mmap.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 8e718fde2f35312c624828c375462bddf67854a3

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/31925/
Subject: LU-10560 llite: remove extra headers from rw26.c
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 2639e47aef9dfa60a9003841d1fe771f1acf900a

[Gerrit Updater]

John L. Hammond ([e-mail]) merged in patch https://review.whamcloud.com/31926/
Subject: LU-10560 lustre_compat: Convert GFP_TEMPORARY to GFP_KERNEL
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 44af4b737ca4dba3bb93cfe6d43f4bab276f5404

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31975/
Subject: LU-10560 osd: bi_bdev is replaced by bi_disk
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 8036c167789ec84488430f8ddeb726b5b11b373c

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32268/
Subject: LU-10560 llite: remove assigning f_version in ll_readir.
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: afd9e3c298ec0149c908026617b06bae075f5760

[Peter Jones]

Landed for 2.12

[Gerrit Updater]

Li Dongyang ([e-mail]) uploaded a new patch: https://review.whamcloud.com/32621
Subject: LU-10560 osd: bio_integrity_enabled was removed
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: d4dc2c9ee0b6260c00e241b6d373b3d98285cd45

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/32621/
Subject: LU-10560 osd: bio_integrity_enabled was removed
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: eee33ef0f07f3f2f5953953416d5d505088ae9a9