[LU-10590] Building tshark lustre disectors fails with a compile error under : lustre_dlm_flags_wshark.c:333:21: error: expected '}' before numeric constant

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.10.2
• Type: Bug
• Priority: Minor
• Reporter: Arshad Hussain
• Assignee: Arshad Hussain
• Resolution: Not a Bug
• Labels: wireshark
• Severity: 3

Description

Building tshark lustre disectors fails with a compile error under : lustre_dlm_flags_wshark.c:333:21: error: expected '}' before numeric constant. As it is missing the comma ',' under lustre/contrib/wireshark/lustre_dlm_flags_wshark.c

Make  failure output.

[root@mrpel7 wireshark]# make
gcc -DINET6 -D_U_=__attribute__\(\(unused\)\) -Wall -Wpointer-arith -g -DXTHREADS -D_REENTRANT -DXUSE_MTSAFE_API -fPIC -DPIC -I/root/mrp/wireshark/wireshark-1.9.2 -I/root/mrp/lustre-xx-3.10/lustre-release/lustre/include -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include  -lglib-2.0   -DHAVE_CONFIG_H   -c -o packet-lustre.o packet-lustre.c
In file included from packet-lustre.c:11423:0:
lustre_dlm_flags_wshark.c: In function 'proto_register_dcerpc_lustre':
lustre_dlm_flags_wshark.c:333:21: error: expected '}' before numeric constant
       /* id      */ HFILL

Fix is to add missing comma. After after the fix it compiles successfully.

# tshark -r ~/truncate.pcap -R "lustre" -T fields -e col.Info
LDLM_ENQUEUE request [Concurrent Read][ intent : lookup ]
LDLM_ENQUEUE reply [Protected Read]
LDLM_ENQUEUE request [Concurrent Write][ intent : open create ][REINT_OPEN] filename :
LDLM_ENQUEUE reply [Concurrent Read]
LDLM_CANCEL request [MINMODE]
LDLM_CANCEL reply
MDS_REINT reply
OST_PUNCH request
OST_PUNCH reply
MDS_CLOSE request [REINT_SETATTR]
MDS_CLOSE reply

Pushing patch shortly.

 

Comments

[Gerrit Updater]

Arshad Hussain ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31109
Subject: LU-10590 wireshark: Add missing comma in lustre_dlm_flags_wshark.c
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: b23cbe947d99b80d11e52a96b81327eb2fb781b4

[Nathaniel Clark]

This is obsoleted by LU-6353. Patch https://review.whamcloud.com/#/c/30602/ removes the entire wireshark plugin from lustre source. The lustre and lnet plugins are now part of wireshark.

[Arshad Hussain]

Wireshark plugin under lustre/contrib is defunct. Not a bug. See Nathaniel's comment on the upstream push.