[LU-10682] o2iblnd txs can be dropped silently Created: 20/Feb/18 Updated: 09/Apr/18 Resolved: 03/Mar/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0, Lustre 2.10.4 |
| Type: | Bug | Priority: | Major |
| Reporter: | Amir Shehata (Inactive) | Assignee: | Amir Shehata (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | None | ||
| Issue Links: |
|
||||
| Severity: | 3 | ||||
| Rank (Obsolete): | 9223372036854775807 | ||||
| Description |
2256 »·······/* grab pending txs while I have the lock */
2257 »·······list_add(&txs, &peer_ni->ibp_tx_queue);
2258 »·······list_del_init(&peer_ni->ibp_tx_queue);
This code is erroneous. We should be moving all the transmits on peer_ni->ibp_tx_queue to the local txs variable then we afterward we iterate through them and send any pending txs. However currently these txs are simply dropped. We should be using list_splice() |
| Comments |
| Comment by Gerrit Updater [ 22/Feb/18 ] |
|
Amir Shehata (amir.shehata@intel.com) uploaded a new patch: https://review.whamcloud.com/31374 |
| Comment by Gerrit Updater [ 03/Mar/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31374/ |
| Comment by Peter Jones [ 03/Mar/18 ] |
|
Landed for 2.11 |
| Comment by Gerrit Updater [ 05/Mar/18 ] |
|
Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31520 |
| Comment by Gerrit Updater [ 05/Apr/18 ] |
|
John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31520/ |