[LU-10737] Checksum calculation takes the error retrun value of cfs_crypto_hash_init as checksum value Created: 28/Feb/18  Updated: 06/Mar/18  Resolved: 06/Mar/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0

Type: Bug Priority: Minor
Reporter: Qian Yingjin (Inactive) Assignee: Qian Yingjin (Inactive)
Resolution: Fixed Votes: 0
Labels: patch

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

In the checksum calculation functions: tgt_checksum_niobuf and osc_checksum_bulk,
it is wrongly taken the failed returun value of cfs_crypto_hash_init as the checksum value.



 Comments   
Comment by Gerrit Updater [ 28/Feb/18 ]

Yingjin Qian (qian@ddn.com) uploaded a new patch: https://review.whamcloud.com/31448
Subject: LU-10737 misc: Wrong checksum return value
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 77fc5b4d7a9091691b8ad37a3631c981dff9c7b4

Comment by Andreas Dilger [ 06/Mar/18 ]

It would be useful to explain a bit about how this problem was found - hit in real life and under what circumstances, hit in testing, or found with code review (manual inspection or static code analysis)?

Comment by Li Xi (Inactive) [ 06/Mar/18 ]

I found this problem when trying to add checksum of checksum for T10PI. And Yingjin run some fault injection test to make sure the fix patch works well.

Comment by Gerrit Updater [ 06/Mar/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31448/
Subject: LU-10737 misc: Wrong checksum return value
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 28b8f3d9296d632a37e36c68c6000dc0c5e96e5a

Comment by Peter Jones [ 06/Mar/18 ]

Landed for 2.11

Generated at Sat Feb 10 02:37:45 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.