[LU-10752] Lustre rpm build issues due to improper lsvcgss packaging

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.11.0, Lustre 2.10.3
• Fix Version/s: Lustre 2.12.0
• Type: Bug
• Priority: Critical
• Reporter: James A Simmons
• Assignee: James A Simmons
• Resolution: Fixed
• Labels: patch
• Severity: 3

Description

For awhile lustre rpms don't build out of the box for ARM or Power8 platforms due to the lustre.spec file being incorrect with lsvcgss handling. This file is a server only file but it currently is installed on clients as well. One some platforms lsvcgss will not be there so it fails to build rpms. Since it was only on ARM or Power8 no big rush was done to resolve this but today I saw it happen on a normal x86 RHEL7  system. So this needs to be pushed so users don't run into RHEL rpm build issues.

Issue Links

• is related to: LU-6387 Add Power8 support to Lustre

Comments

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31485
Subject: LU-10752 build: properly package lsvcgss for rpm builds
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 2f0d08e284b453c086723c8cc78a0780fbac5379

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31485/
Subject: LU-10752 build: properly package lsvcgss for rpm builds
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: a34ba90453b8bb8de9bcdf949f8afc4c2a43f393

[Peter Jones]

Landed for 2.11

[Amir Shehata (Inactive)]

With this patch "make rpms" fails if keyutils-libs-devel is not installed.

The package has to be installed or --disable-gss-keyring must be specified.

I don't think this is the correct behavior.

[James A Simmons]

I can fix that. The autoconf support for GSS is very fragile  So even when libkeyutils is missing gss-keyring is enabled. That is really broken.

[James A Simmons]

So looking at the GSS autoconf handling I noticed both a --enable-gss and --enable-gss-keyring. The --enable-gss is for clients and servers and --enable-gss-keyring is just servers. So lgssc.conf should be installed when --enable-gss=yes and be indepenent of --enable-gss-keyring. Also if enable-gss-keyring is done we should force enable-gss. I will do some testing for that case.

[Gerrit Updater]

James Simmons ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31757
Subject: LU-10752 build: properly package lgssc.conf for rpm builds
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 11681ac0efd116171baf32fd31679e999d15fcb4

[James A Simmons]

This should resolve all the issues

 

[Peter Jones]

Seems to still be in flux

[James A Simmons]

Sebastien pointed out that the lgssd.conf file is server only. Latest version of the patch resolves that issue. Otherweise the patch was good. Speaking of packaging I also noticed that GSS server stuff is only packaged for RHEL systems. You can build on SuSE servers but not package it  

[James A Simmons]

Wow a person that builds lustre with mock. The latest version of the patch should make Lustre build with mock.

[Elena Gryaznova]

build still fails with --disable-gss

[James A Simmons]

Boy this has been challenging. The latest patch should support both make rpm and mock build systems. For building from the source rpms GSS will be by default disabled. Its to not easy to know if the kernel the rpm is being built against is too new for GSS and the spec file does not handle the GSS buiild dependencies. I also have fixed up make rpms to handle both the various combos of enable-gss and enable-gss-keyrings now. Let me know if this works.

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31757/
Subject: LU-10752 build: fix rpm packaging issues for gss
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 6189ae07c5161d14c9e9f863a400045f923f2301

[Peter Jones]

Landed for 2.12