[LU-10764] Incorrect code in ct_archive Created: 05/Mar/18  Updated: 19/Mar/18  Resolved: 15/Mar/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.11.0, Lustre 2.10.4

Type: Bug Priority: Minor
Reporter: Oleg Drokin Assignee: Oleg Drokin
Resolution: Fixed Votes: 0
Labels: None

Severity: 3
Rank (Obsolete): 9223372036854775807

 Description   

It contains this lovely code:

                        if (sz == 0 || strncmp(buf, dst, sz) != 0) {
                                if (unlink(src) && errno != ENOENT) {
                                        CT_ERROR(errno,
                                                 "cannot unlink symlink '%s'",
                                                 src);
                                        rcf = rcf ? rcf : -errno;
                                        goto fini_minor;
                                /* unlink old symlink done */
                                CT_TRACE("remove old symlink '%s' pointing"
                                         " to '%s'", src, buf);
                                }

Clearly we want the closing bracket after the goto, so the TRACE could be printed.

 Comments   
Comment by Oleg Drokin [ 05/Mar/18 ]

proposed patch in https://review.whamcloud.com/31509

Comment by Gerrit Updater [ 15/Mar/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31509/
Subject: LU-10764 hsm: Correct debug print in ct_archive
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: debba58308fd4c493fcde22094b4aa49b03988c1

Comment by Peter Jones [ 15/Mar/18 ]

Landed for 2.11

Comment by Gerrit Updater [ 15/Mar/18 ]

Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31667
Subject: LU-10764 hsm: Correct debug print in ct_archive
Project: fs/lustre-release
Branch: b2_10
Current Patch Set: 1
Commit: 9d8b3a70f0dcfb6f91064b7a8f2de4791e779a5d

Comment by Gerrit Updater [ 19/Mar/18 ]

John L. Hammond (john.hammond@intel.com) merged in patch https://review.whamcloud.com/31667/
Subject: LU-10764 hsm: Correct debug print in ct_archive
Project: fs/lustre-release
Branch: b2_10
Current Patch Set:
Commit: 70f53ec333f0f1d24fbc5b7ace691ceb66ba8506

Generated at Sat Feb 10 02:37:59 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.