[LU-10765] Broken error fs handling in llapi_hsm_action_{begin,end} Created: 05/Mar/18 Updated: 29/Jan/22 |
|
| Status: | Open |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | None |
| Type: | Bug | Priority: | Minor |
| Reporter: | Oleg Drokin | Assignee: | WC Triage |
| Resolution: | Unresolved | Votes: | 0 |
| Labels: | easy | ||
| Severity: | 3 |
| Rank (Obsolete): | 9223372036854775807 |
| Description |
|
Both llapi_hsm_action_begin/end have this code in error handling: err_out:
if (!(hcp->source_fd < 0))
close(hcp->source_fd);
The problem is source_fd is unsigned, so it could never be less than zero. |