[LU-1078] two minor issues in lnet

• Status: Resolved
• Project: Lustre
• Affects Version/s: Lustre 2.0.0, Lustre 2.1.0, Lustre 1.8.x (1.8.0 - 1.8.5)
• Fix Version/s: Lustre 2.3.0
• Type: Bug
• Priority: Trivial
• Reporter: Isaac Huang (Inactive)
• Assignee: Bob Glossman (Inactive)
• Resolution: Fixed
• Labels: lnet, selftest

Description

I recently noticed these:

1. The doxygen comment above LNetNIInit in lnet/lnet/api-ni.c says:
"return 0 on success, and non-zero error code on failures."

This is wrong. LNetNIInit can return > 0 on success.

2. In lst_test_add_ioctl()

753 LIBCFS_ALLOC(dstgrp, args->lstio_tes_dgrp_nmlen + 1);
754 if (srcgrp == NULL)$
755 goto out;

In line 754, s/srcgrp/dstgrp/?

I don't have time to fix and test and so on. Please fix them.

Comments

[Andreas Dilger]

I don't have time to fix and test and so on. Please fix them.

Isaac,
as you can well imagine, everyone is busy with projects of their own as well, so the best way to fix minor issues like this is to do it yourself. The time it takes to submit a patch for such a minor change is very minimal with the new automated build and test system. Creating a patch, commit it to Git with a proper commit comment referencing this LU-1078 ticket (see http://wiki.whamcloud.com/display/PUB/Commit+Comments for details), pushing it to Gerrit, and asking for reviews is sufficient, since the patch will be built and tested automatically before it could land in any case.

[Isaac Huang (Inactive)]

Well, please reassign it to me then. When I have a chance I'll have a look at the document and fix it.

[Peter Jones]

Minh

Why don't you clean these LNET issues up when you get a chance?

Thanks

Peter

[Minh Diep]

sure

[Peter Jones]

Reassigning to Bob

[Bob Glossman (Inactive)]

http://review.whamcloud.com/#change,2692

[Peter Jones]

Landed for 2.3