[LU-10788] __vfs_setxattr() should pass flags through

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.12.0
• Type: Bug
• Priority: Minor
• Reporter: John Hammond
• Assignee: John Hammond
• Resolution: Fixed
• Severity: 3

Description

In the compat definition of __vfs_setxattr() we should pass the value of flags that we received rather than XATTR_CREATE:

#ifdef HAVE_XATTR_HANDLER_FLAGS
static inline int
__vfs_setxattr(struct dentry *dentry, struct inode *inode, const char *name,
               const void *value, size_t size, int flags)
{
        const struct xattr_handler *handler;
        int rc;

        handler = get_xattr_type(name);
        if (!handler)
                return -ENXIO;

#if defined(HAVE_XATTR_HANDLER_INODE_PARAM)
        rc = handler->set(handler, dentry, inode, name, value, size,
                          XATTR_CREATE);
#elif defined(HAVE_XATTR_HANDLER_SIMPLIFIED)
        rc = handler->set(handler, dentry, name, value, size, XATTR_CREATE);
#else
        rc = handler->set(dentry, name, value, size, XATTR_CREATE,
                          handler->flags);
#endif /* !HAVE_XATTR_HANDLER_INODE_PARAM */
        return rc;
}

This is minor now since we only pass XATTR_CREATE to __vfs_setxattr().

Issue Links

• is related to: LU-9679 Prepare lustre for adoption into the ...

Comments

[Gerrit Updater]

John L. Hammond ([e-mail]) uploaded a new patch: https://review.whamcloud.com/31593
Subject: LU-10788 llite: pass flags through __vfs_setxattr()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 92a4954394364d351c30eb17055504223b686542

[Gerrit Updater]

Oleg Drokin ([e-mail]) merged in patch https://review.whamcloud.com/31593/
Subject: LU-10788 llite: pass flags through __vfs_setxattr()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: 4753bae7f3939ff08e70cf9efc1a26b4bf2d29fe

[Peter Jones]

Landed for 2.12