[LU-10803] req_buffers_max and req_history_max setting problems Created: 12/Mar/18 Updated: 07/Jan/19 Resolved: 15/Mar/18 |
|
| Status: | Resolved |
| Project: | Lustre |
| Component/s: | None |
| Affects Version/s: | None |
| Fix Version/s: | Lustre 2.11.0 |
| Type: | Bug | Priority: | Minor |
| Reporter: | Wang Shilong (Inactive) | Assignee: | Bruno Faccini (Inactive) |
| Resolution: | Fixed | Votes: | 0 |
| Labels: | patch | ||
| Issue Links: |
|
||||||||
| Severity: | 3 | ||||||||
| Rank (Obsolete): | 9223372036854775807 | ||||||||
| Description |
|
We hit we found two problems:
1)Since 0 is a reserved value for @srv_nrqbds_max which means unlimited value, procfs write interface should support this value, otherwise, there is no way to change default behavior back.
2)the check in ptlrpc_lprocfs_req_history_max_seq_write() was broken after this patch, the following check will always succeed if @srv_nrqbds_max is kept as default value 0:
val > svc->srv_nrqbds_max/2
|
| Comments |
| Comment by Wang Shilong (Inactive) [ 12/Mar/18 ] |
|
Here is patch:
|
| Comment by Bruno Faccini (Inactive) [ 12/Mar/18 ] |
|
Nice catch! And thanks for the patch.
|
| Comment by Gerrit Updater [ 15/Mar/18 ] |
|
Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31622/ |
| Comment by Peter Jones [ 15/Mar/18 ] |
|
Landed for 2.11 |
| Comment by Gerrit Updater [ 15/Mar/18 ] |
|
Minh Diep (minh.diep@intel.com) uploaded a new patch: https://review.whamcloud.com/31665 |