[LU-10819] kiblnd_peer_connect_failed() uses list_add() backwards Created: 14/Mar/18  Updated: 19/Dec/18  Resolved: 09/Apr/18

Status: Resolved
Project: Lustre
Component/s: None
Affects Version/s: None
Fix Version/s: Lustre 2.12.0

Type: Bug Priority: Minor
Reporter: John Hammond Assignee: John Hammond
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Duplicate
duplicates LU-10882 list bug in kiblnd_peer_connect_faile... Resolved
Severity: 3
Rank (Obsolete): 9223372036854775807

 Description    
static void
kiblnd_peer_connect_failed(kib_peer_ni_t *peer_ni, int active, int error)
...
        if (list_empty(&peer_ni->ibp_conns)) {
                /* Take peer_ni's blocked transmits to complete with error */
                list_add(&zombies, &peer_ni->ibp_tx_queue);
                list_del_init(&peer_ni->ibp_tx_queue);

                if (kiblnd_peer_active(peer_ni))
                        kiblnd_unlink_peer_locked(peer_ni);

                peer_ni->ibp_error = error;
        } else {


 Comments   
Comment by Gerrit Updater [ 14/Mar/18 ]

John L. Hammond (john.hammond@intel.com) uploaded a new patch: https://review.whamcloud.com/31643
Subject: LU-10819 o2ib: use splice in kiblnd_peer_connect_failed()
Project: fs/lustre-release
Branch: master
Current Patch Set: 1
Commit: 425a0e265e611aac120f8bb119a3dd2e075d109a

Comment by John Hammond [ 15/Mar/18 ]

I see now that this code is not exactly broken just very weird. We should fix it, but it is not the cause of LU-10800.

Comment by Gerrit Updater [ 09/Apr/18 ]

Oleg Drokin (oleg.drokin@intel.com) merged in patch https://review.whamcloud.com/31643/
Subject: LU-10819 o2ib: use splice in kiblnd_peer_connect_failed()
Project: fs/lustre-release
Branch: master
Current Patch Set:
Commit: f3824b978efe810f4cca42e75f09b5a9860178c5

Comment by Peter Jones [ 09/Apr/18 ]

Landed for 2.12

Generated at Sat Feb 10 02:38:28 UTC 2024 using Jira 9.4.14#940014-sha1:734e6822bbf0d45eff9af51f82432957f73aa32c.