[LU-1084] Console messages from sec stuff MUST GO

• Status: Resolved
• Project: Lustre
• Fix Version/s: Lustre 2.2.0, Lustre 2.1.2
• Type: Bug
• Priority: Minor
• Reporter: Christopher Morrone
• Assignee: Minh Diep
• Resolution: Fixed
• Severity: 3

Description

The copious amounts of CWARN console messages for completely normal expected events need to be removed from lustre/ptlrpc/sec.c and anything else associated.

For bonus points: Beat the original author with a wet noodle.

Comments

[Peter Jones]

Minh

Could you please have a look at this one?

Peter

[Andreas Dilger]

There was a patch landed to master for 2.2 in http://review.whamcloud.com/1876 which removed among other things the spurious SEC messages (at least one, I'm not sure which one you are referring to), and there is another patch which quiets a few messages http://review.whamcloud.com/2015 (mostly in test scripts, but a few console messages).

I'm happy to remove more of them if you can point them out specifically.

[Christopher Morrone]

I did check master, but the only patch on master that made a significant change was one from you that did this:

-                CWARN("import %s->%s netid %x: select flavor %s\n",
-                      imp->imp_obd->obd_name,
-                      obd_uuid2str(&conn->c_remote_uuid),
-                      LNET_NIDNET(conn->c_self),
-                      sptlrpc_flavor2name(&sf, str, sizeof(str)));
+        } else if (SPTLRPC_FLVR_BASE(sf.sf_rpc) !=
+                   SPTLRPC_FLVR_BASE(SPTLRPC_FLVR_NULL)) {
+                LCONSOLE_INFO("import %s->%s netid %x: select flavor %s\n",
+                              imp->imp_obd->obd_name,
+                              obd_uuid2str(&conn->c_remote_uuid),
+                              LNET_NIDNET(conn->c_self),
+                              sptlrpc_flavor2name(&sf, str, sizeof(str)));

But I would like to take that message (and most of the other CWARN messages in that file) off of the console all together.

[Christopher Morrone]

http://review.whamcloud.com/2135

[Minh Diep]

monitoring the testing on this patch

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_bulk.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el5,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_null.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,ubuntu1004,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_bulk.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,sles11,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el5,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_config.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el5,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_config.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_null.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el5,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_bulk.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_null.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_null.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec_null.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_config.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,client,el6,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_config.c

[Build Master (Inactive)]

Integrated in lustre-master » x86_64,server,el6,inkernel #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_config.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,client,el6,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_config.c
• lustre/ptlrpc/sec.c

[Build Master (Inactive)]

Integrated in lustre-master » i686,server,el6,ofa #483
LU-1084 ptlrpc: Change CWARNs to CDEBUGs (Revision b6397a72d655eb24df53227a74a1f57de8f2313a)

Result = SUCCESS
Oleg Drokin : b6397a72d655eb24df53227a74a1f57de8f2313a
Files :

• lustre/ptlrpc/sec.c
• lustre/ptlrpc/sec_null.c
• lustre/ptlrpc/sec_plain.c
• lustre/ptlrpc/sec_gc.c
• lustre/ptlrpc/sec_bulk.c
• lustre/ptlrpc/sec_config.c

[Minh Diep]

landed in master

[Bob Glossman (Inactive)]

http://review.whamcloud.com/#change,2621
back port to b2_1